1737676 - Use native GTK menu radius.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1737676 - Use GTK menu radius on native context menus and panels. r=stransky

Comment 2

[Emilio Cobos Álvarez [:emilio]]

The patch above works nicely on all the GTK themes I've tried except Yaru for some reason. But I think it should work because Yaru has a rule like:

  .csd menu, .csd .menu, .csd .context-menu {
    border: none;
    border-radius: 4px; }

Do you know why it might not be working as expected there, or how can I debug it further? GTK_DEBUG=interactive doesn't seem to show the WidgetStyleCache widgets.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

I made it work by falling back to the decoration style, but not sure if that's acceptable or not, didn't quite figure out why it didn't work out of the box.

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

I made it work by falling back to the decoration style, but not sure if that's acceptable or not, didn't quite figure out why it didn't work out of the box.

I think this is the correct approach - we use the same way to do header bar styles. I recall the direct style assignment you used at CreateWindowWidget() doesn't work as expected for gtk > 3.20 due to style rework (AFAIK styles from widgets are not used to create the css selector or so).

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

So it looks correct to me but just check actual window setup (csd/solid-csd) and don't use radius with solid-csd (set to 0 ?).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f533a2776f76
Use GTK menu radius on native context menus and panels. r=stransky

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f533a2776f76