1737770 - [Experiment] The Firefox logo icon is wrongly displayed instead of the "umbrella" one on the "emotive-pin-firefox-modal" from the "Treatment B" branch

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: ss of the issue.png

[Affected versions]:

• Firefox Release 93.0 - Build ID: 20210927210923
• Firefox Beta 94.0 - Build ID: 20211025220926

[Affected Platforms]:

• Windows 10 x64

[Prerequisites]:

• Have a Firefox profile older than 28 days.
• Have this user.js file saved to your PC.
• Have at least 1 URL accessed in the last 13 days.
• The Firefox browser is not pinned to the taskbar.

[Steps to reproduce]:

1. Navigate to the profile folder from prerequisites and paste the "user.js" file.
2. Open the browser with the profile from prerequisites.
3. Observe the icon from the "Pin to taskbar" modal.

[Expected result]:

• An "umbrella" icon is displayed in the top part of the modal.

[Actual result]:

• The Firefox logo is displayed instead.

[Notes]:

• Attached a screenshot of the issue.

Comment 1

[Ed Lee :Mardak]

We're expecting the image to become available at https://www.mozilla.org/media/img/firefox/onboarding/umbrella.041dbea876c4.png as added in https://github.com/mozilla/bedrock/issues/10632 but it has not been deployed to production yet.

Comment 2

[Ed Lee :Mardak]

The image is now on stage. I'll update nimbus recipe when it gets to prod.

https://www.allizom.org/media/img/firefox/onboarding/umbrella.041dbea876c4.png

Comment 3

[Ed Lee :Mardak]

Doh. Recipe is updated but content security on the modal prevents loading https or data URIs.

Content Security Policy: The page’s settings blocked the loading of a resource at https://www.mozilla.org/media/img/firefox/onboarding/umbrella.041dbea876c4.png (“default-src”).

Comment 4

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Would like to ride along to 94 to show a more emotive image than just the firefox logo. If not for this specific experiment, there are others planned to run in November.

Comment 5

[Ed Lee :Mardak]

Attachment: Bug 1737770 - Allow spotlight messaging modal to show images from mozilla r=andreio a?release

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f38bcae5f766
Allow spotlight messaging modal to show images from mozilla r=andreio

Comment 7

[Ed Lee :Mardak]

Marius, seems like we'll use the Firefox logo in treatment b to launch the experiment now. But we're fixing this bug to allow umbrella and other images for future experiments in 95 and potentially 94 if uplifted. As of right now, emotive-pin-firefox-modal still is configured to try to show umbrella for treatment b, so if this code change lands, you could verify that umbrella shows up in nightly.

But depending on when we actually launch it, the image will be switched to firefox logo. So to verify, we'll need a different experiment/preview that uses the umbrella, so maybe I'll make a clone of the experiment in preparation for a separate upcoming experiment (sounds like there's at least 2 more planned for November).

Comment 8

[Ed Lee :Mardak]

Here's a new experiment on preview that currently uses the umbrella (only 1/control branch):
https://experimenter.services.mozilla.com/nimbus/peace-of-mind-casual-modal

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f38bcae5f766

Comment 10

[Ed Lee :Mardak]

Comment on attachment 9247884 [details]
Bug 1737770 - Allow spotlight messaging modal to show images from mozilla r=andreio a?release

Beta/Release Uplift Approval Request

• User impact if declined: Emotive messaging experiments are less exciting with a generic Firefox logo
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes comment 13
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Enroll into https://experimenter.services.mozilla.com/nimbus/peace-of-mind-casual-modal
  a. Set nimbus.debug to true
  b. Navigate to about:studies?optin_slug=peace-of-mind-casual-modal&optin_branch=control&optin_collection=nimbus-preview

2. Force show peace-of-mind-casual-modal message
   a. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
   b. Open new tab
   c. Click devtools wrench in top right
   d. Find in page "peace-of-mind-casual-modal"
   e. Click "Show" for the message
   (Might need to restart Firefox if already opened a new tab and message doesn't show up.)

• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Allows loading of images like other Firefox experiment messaging surfaces. Patch updated for 94 release uplift https://phabricator.services.mozilla.com/D129577 (release try https://treeherder.mozilla.org/jobs?repo=try&revision=17b57b4c4f1444ec9fdbf939be82e932c1e68111)
• String changes made/needed: none

Comment 11

[Ed Lee :Mardak]

Noticed there's a beta code conflict with bug 1733623, which only landed on 95. I'll update the patch for beta.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9247884 [details]
Bug 1737770 - Allow spotlight messaging modal to show images from mozilla r=andreio a?release

94 is on release now.

Comment 13

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible, using the steps that Ed provided in comment 10, with the latest Firefox Nightly (95.0a1 Build ID - 20211027214117) installed on Windows 10 x64, macOS 11.6, and Linux Mint 20.2 x64. Now, I can confirm that the "umbrella" logo is successfully displayed in the top part of the "peace-of-mind-casual-modal".

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9247884 [details]
Bug 1737770 - Allow spotlight messaging modal to show images from mozilla r=andreio a?release

Approved for 94.0rc2.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/ece69f2fe88f

Comment 16

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible, using the steps that Ed provided in comment 10, with the latest Firefox Beta RC (94.0 Build ID - 20211028161635) installed on Windows 10 x64, macOS 11.6, and Linux Mint 20.2 x64. Now, I can confirm that the "umbrella" logo is successfully displayed in the top part of the "peace-of-mind-casual-modal".