1737785 - Cancel/ Add buttons are moved when Edit this site is opened

Status: NEW

(Firefox :: New Tab Page, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: edit_site.gif

Affected versions

• 95.0a1 (20211020093007)
• 94.0 (20211025220926)

Affected platforms

• Windows 10 x64
• macOS 10.15
• Ubuntu 21.04

Steps to reproduce

1. Open Firefox and click on Edit this site from the Top Sites section.
2. Observe the new window Cancel/ Add buttons.

Expected result

• Panel is opened as expected.

Actual result

• Cancel/ Add buttons are moved and resized when the window is opened.

Regression range

• From what I saw this started with bug 1613705. After this bug, the Cancel button is slighty moved when the window is opened. This is harder to be seen.

• Then after bug 1727321, the Add button is moving as well.

Notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco]]

:atrif, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 2

[Alexandru Trif, Desktop Test Engineering [:atrif]]

I will put bug 1727321 as the regressor since this made things more visible in my opinion.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1727321

Comment 4

[Amy Churchwell [:amy]]

Thank you for reporting. Struggling to reproduce, is this still an issue on your side?

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: edit_this.gif

(In reply to Amy Churchwell [:amy] from comment #4)

Thank you for reporting. Struggling to reproduce, is this still an issue on your side?

Yup, the issue is still reproducible with the latest Firefox Nightly 97.0a1 (2022-01-04). It can be seen better while entering and exiting the window rapidly with the Esc key.

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: screenshot of brief misrendering in Nightly 132

This is still reproducible in Nightly 132.0a1 (2024-09-21) (64-bit).

Here's a screenshot showing the (very brief) intermediate state, from a screencast that I just captured locally. As shown here, the issue (in this case at least) was that the buttons have no text inside of them, which means their height collapses. Also, the "Use a custom image..." text is missing here.

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: screenshot of correct rendering (that we land on after the brief misrendering)