1737789 - Edit this site button remains selected if Esc is used to close it's corresponding window

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: edit_site_01.gif

Affected versions

• 95.0a1 (20211020093007)
• 94.0 (20211025220926)
• 93.0 (20210927210923)
• 91.2.0esr (20210927140538)
• 78.15.0esr (20210927121355)

Affected platforms

• Windows 10 x64
• macOS 10.15
• Ubuntu 21.04

Steps to reproduce

1. Open Firefox and click on Edit this site from the Top Sites section.
2. Hit Esc key.

Expected result

• Edit this site button is not displayed if not hovered.

Actual result

• Edit this site button remains in the selected state.

Regression range

• I don’t think this is a regression, the Edit this site button remains selected on Nightly 69.0a1(2019-05-31) when the functionality to exit with Esc key was added.

Notes

• Attached a screen recording.
• This can be reproduced if the Edit this site button is dragged. Same on Open Menu button

Comment 1

[Dale Harvey (:daleharvey)]

Hi Morgan, We could reproduce this but it looks like it could be expected behaviour since the button will still be active once the dialog is dismissed. Was wondering from an accessibility perspective whether this is what you would expect or not. Thanks

Comment 2

[Morgan Reschenberg [:morgan]]

(In reply to Dale Harvey (:daleharvey) from comment #1)

Hi Morgan, We could reproduce this but it looks like it could be expected behaviour since the button will still be active once the dialog is dismissed. Was wondering from an accessibility perspective whether this is what you would expect or not. Thanks

It's hard to say, since this button's focused and active states are the same visually. If the button is focused with the keyboard, activated, and then the dialog is closed, I'd expect the button to remain focused and visible.

If the button is clicked with the mouse and then the dialog is closed, I would not expect the button to remain active/selected or visible (unless the mouse was still hovering the button).

This is pretty similar in functionality to the "colors" button in preferences, which launches a dialog when activated (albiet without the hover).

Comment 3

[Scott [:thecount] Downe]

I think we can close this.

I tested this, and we now have an edit option in a context menu from a previous UI update.

If you click it, it open the edit dialog and closes the context menu.

If you then close the edit dialog, nothing is left in an active, hover, or selected state.

So I think that previous UI update adding the context menu fixed this.

Feel free to reopen or comment if I missed something that should still be address.