1737814 - Refactor ListFormat::FormatToParts

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P4)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

There are some improvements learned from DateTimeFormat implementation that could help ListFormat::FormatToParts, for example:

1. No need to use a callback.
   We could pass a Buffer, and that buffer holds the string result, so the strings got for ICU could still remain valid after the FormatToParts call.
   Also, when I implemented DateIntervalFormat, I found std::function will do heap allocation when the lambda size is too large.

2. Simplify the data structures in ListFormat::Part.
   We could just store an index to the string buffer, instead of a Mozilla::Span.

Comment 1

[Greg Tatum [:gregtatum]]

Marking this as P4 since it's on the non-critical path for unification, that way it won't show up in the graph for the KRs. Feel free to continue the clean-up on it though.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1737814 - Part 1: Add a AutoFormatResult class.

This AutoFormatResult class could be shared later by ListFormat.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1737814 - Part 2: ListFormat.FormatToParts doesn't take a callback.

The caller now will provide a buffer, which owns the memory pointed by the span.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1737814 - Part 3: Simplify parts data structure.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9459574a7ee2
Part 1: Add a AutoFormatResult class. r=platform-i18n-reviewers,anba,gregtatum
https://hg.mozilla.org/integration/autoland/rev/a3a54dca1620
Part 2: ListFormat.FormatToParts doesn't take a callback. r=platform-i18n-reviewers,anba,gregtatum
https://hg.mozilla.org/integration/autoland/rev/0480317c00e5
Part 3: Simplify parts data structure. r=platform-i18n-reviewers,anba,gregtatum

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9459574a7ee2
https://hg.mozilla.org/mozilla-central/rev/a3a54dca1620
https://hg.mozilla.org/mozilla-central/rev/0480317c00e5