Crash in [@ mozilla::dom::JSStreamConsumer::OnInputStreamReady]
Categories
(Core :: JavaScript: WebAssembly, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox-esr91 | --- | unaffected |
firefox93 | --- | unaffected |
firefox94 | --- | unaffected |
firefox95 | + | fixed |
firefox96 | --- | fixed |
People
(Reporter: aryx, Assigned: yury)
References
(Regression)
Details
(Keywords: crash, regression)
Crash Data
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
See also bug 1737405
9 crashes from 9 different devices, crashes predominantly on twitch.tv
Maybe Fission related. (DOMFissionEnabled=1)
Crash report: https://crash-stats.mozilla.org/report/index/4e3e62a9-d58e-4e8d-9725-0068f0211026
MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(ok) (corrupt optimized wasm cache file)
Top 10 frames of crashing thread:
0 xul.dll mozilla::dom::JSStreamConsumer::OnInputStreamReady dom/fetch/FetchUtil.cpp:542
1 xul.dll mozilla::`anonymous namespace'::InputStreamCallbackRunnable::Run dom/file/ipc/RemoteLazyInputStream.cpp:54
2 xul.dll static mozilla::`anonymous namespace'::InputStreamCallbackRunnable::Execute dom/file/ipc/RemoteLazyInputStream.cpp:48
3 xul.dll mozilla::RemoteLazyInputStream::AsyncWait dom/file/ipc/RemoteLazyInputStream.cpp:460
4 xul.dll mozilla::dom::JSStreamConsumer::OnInputStreamReady dom/fetch/FetchUtil.cpp:577
5 xul.dll mozilla::`anonymous namespace'::InputStreamCallbackRunnable::Run dom/file/ipc/RemoteLazyInputStream.cpp:54
6 xul.dll static mozilla::`anonymous namespace'::InputStreamCallbackRunnable::Execute dom/file/ipc/RemoteLazyInputStream.cpp:48
7 xul.dll mozilla::RemoteLazyInputStream::OnInputStreamReady dom/file/ipc/RemoteLazyInputStream.cpp:581
8 xul.dll nsPipeEvents::~nsPipeEvents xpcom/io/nsPipe3.cpp:1142
9 xul.dll nsPipeOutputStream::WriteSegments xpcom/io/nsPipe3.cpp:1715
Comment 1•3 years ago
|
||
Assigning to Yury for investigation, this is the kind of thing that will need an uplift if it doesn't land before merge day, etc.
Reporter | ||
Comment 2•3 years ago
|
||
[Tracking Requested - why for this release]:
this is the kind of thing that will need an uplift if it doesn't land before merge day, etc.
Updated•3 years ago
|
Comment 3•3 years ago
•
|
||
FWIW, this is the assert that would fail if the cache file gets corrupted. If there aren't any clear correlations (to a particular URL or configuration), the "fix" might be to downgrade the MOZ_DIAGNOSTIC_ASSERT() into a plain MOZ_ASSERT() (which was already the motivation of having a MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_RELEASE_ASSERT()); the if (!ok)
branch right after the assert ensures graceful failure.
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 8•3 years ago
|
||
Comment hidden (Intermittent Failures Robot) |
Comment 10•3 years ago
|
||
Pushed by ydelendik@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3dd08e02c0c2 Fix truncated storeOptimizedEncoding stream. r=jandem
Reporter | ||
Comment 11•3 years ago
|
||
Please request uplift for the patch.
Assignee | ||
Comment 12•3 years ago
|
||
Comment on attachment 9248339 [details]
Bug 1737837 - Fix truncated storeOptimizedEncoding stream. r?jandem
Beta/Release Uplift Approval Request
- User impact if declined: broken loading of WebAssembly module; crashing
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): trivial patch (that prevents data corruption)
- String changes made/needed:
Comment 13•3 years ago
|
||
Comment on attachment 9248339 [details]
Bug 1737837 - Fix truncated storeOptimizedEncoding stream. r?jandem
Approved for 95.0b1.
Comment 14•3 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 15•3 years ago
|
||
bugherder |
Comment 16•3 years ago
|
||
This is still appearing.
Yury, could you please take a look? Should we make a new bug to track this issue?
Comment hidden (Intermittent Failures Robot) |
Comment 18•3 years ago
|
||
Filed Bug 1738987 to track the new issue.
Assignee | ||
Comment 19•3 years ago
|
||
Agree. Something else if going on, perhaps inflate(&self->mZStream, Z_NO_FLUSH);
needs flushing, I'll track this in the bug 1738987
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•2 years ago
|
Description
•