1737853 - taskgraph --diff does not account for repo specific module names

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

When performing '--diff' we need to reload taskgraph modules in 'sys.path', otherwise changes made there across revisions won't get picked up. We do this here:
https://hg.mozilla.org/ci/taskgraph/file/tip/src/taskgraph/main.py#l395

However this neglects the consumer specific taskgraph repos which typically follow the format <project>_taskgraph as the module name. This means any changes to such modules get ignored by --diff as the module wasn't being reloaded.

As long as we can assume that the <project>_taskgraph convention holds true, we can simply change this check to mod.split(".")[0].endswith("taskgraph"). Though there's no real requirement that this convention is used. Solving this properly might involve officially registering module(s) that contain taskgraph related logic.

For now though, I think we should take the above change, as it is a clear improvement and will solve all of our current use cases.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1737853 - Fix '--diff' to account for consumer specific module names, r?#taskgraph-reviewers

Previously we were only reloading the main taskgraph module. This meant that
changes to e.g, fenix_taskgraph or gecko_taskgraph were being ignored when
using --diff.

Though this still assumes that the '<project>_taskgraph' convention is used.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/ci/taskgraph/rev/c3b465290f7d
Fix '--diff' to account for consumer specific module names, r=taskgraph-reviewers,jmaher

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1737853 - [taskgraph] Fix '--diff' to account for new 'gecko_taskgraph' module name, r?#taskgraph-reviewers

I forgot to update the module name in the new '--diff' feature when renaming
the module to 'gecko_taskgraph'.

This syncs the commit to standalone taskgraph here:
https://hg.mozilla.org/ci/taskgraph/rev/c3b465290f7dae51d603f29dff704f4ea17db766

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42358b28de12
[taskgraph] Fix '--diff' to account for new 'gecko_taskgraph' module name, r=taskgraph-reviewers,jmaher

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/42358b28de12