1737880 - [wpt-sync] Sync PR 31387 - Update letterSpacing and wordSpacing to accept Strings

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 31387 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31387
Details from upstream follow.

Yi Xu <[e-mail]> wrote:

Update letterSpacing and wordSpacing to accept Strings

letterSpacing and wordSpacing used to take doubles that represent
spacing in pixels, which limited users to take specify spacing based on
ems. This patch now make letterSpacing and wordSpacing to take Strings,
so users has the flexibility to use different units as em, px, cm, mm,
etc.

Bug: 1263632

Change-Id: I40a219a57462ce749b44de6e7c3b5c885753c95e

Reviewed-on: https://chromium-review.googlesource.com/3244342
WPT-Export-Revision: 5008e7f6350fd6e80848675d33295a6614098ac2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=66565140997a7b929cc6ae373365d7e704bbf0c5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 9
FAIL: 9

Chrome

OK : 9
FAIL: 9

Safari

OK : 9
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/offscreen/text/2d.text.drawing.style.nonfinite.spacing.html
Testing letter spacing and word spacing with nonfinite inputs: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.drawing.style.nonfinite.spacing.html
Testing letter spacing and word spacing with nonfinite inputs: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.nonfinite.spacing.worker.html
Testing letter spacing and word spacing with nonfinite inputs: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.drawing.style.spacing.html
Testing letter spacing and word spacing: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.spacing.html
Testing letter spacing and word spacing: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/element/drawing-text-to-the-canvas/2d.text.drawing.style.spacing.measure.html
Testing letter spacing and word spacing: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.spacing.measure.html
Testing letter spacing and word spacing: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.spacing.measure.worker.html
Testing letter spacing and word spacing: FAIL (Chrome: FAIL, Safari: FAIL)
/html/canvas/offscreen/text/2d.text.drawing.style.spacing.worker.html
Testing letter spacing and word spacing: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55f02638b8dd
[wpt PR 31387] - Update letterSpacing and wordSpacing to accept Strings, a=testonly

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/55f02638b8dd