1737893 - WPT test preserve-3d-flat-grouping-properties.html accidentally squishes its pass/fail output to be unreadable

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Daniel Holbert [:dholbert]]

WPT test preserve-3d-flat-grouping-properties.html has this styling, which is intended to target all of its tested div elements:

  div {
    width: 200px;
    height: 200px;
  }

Unfortunately, that rule also makes its pass/fail results unreadable (since they are div elements which match that^ CSS rule.)

Let's fix this so that it's easier to see the test-pass/fail results.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1737893: Add wrapper-div to WPT test preserve-3d-flat-grouping-properties.html, to avoid accidental restyling of human-readable test-results divs. r?#layout-reviewers

Note that this commit shouldn't change the test's pass/fail status anywhere. It
just makes the test results possible to read.

Comment 2

[Daniel Holbert [:dholbert]]

Note, you can see the live test itself here: https://wpt.live/css/css-transforms/preserve-3d-flat-grouping-properties.html

If you scroll down a bit, you can see the squashed pass/fail logging that I'm fixing here.

Comment 3

[Daniel Holbert [:dholbert]]

CC'ing chrishtr who wrote this test -- Chris, feel free to weigh in if you have any concerns about this change. I don't imagine it's controversial, given that it's ~non-functional and just makes the output possible to see. :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/381d9dd110a9
Add wrapper-div to WPT test preserve-3d-flat-grouping-properties.html, to avoid accidental restyling of human-readable test-results divs. r=emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/31389 for changes under testing/web-platform/tests

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/381d9dd110a9

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot