Remove lodash difference usage
Categories
(DevTools :: Debugger, task)
Tracking
(firefox98 fixed)
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: saihemanth9019)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
It seems to only be used from https://searchfox.org/mozilla-central/rev/f8576fec48d866c5f988baaf1fa8d2f8cce2a82f/devtools/client/debugger/src/components/PrimaryPanes/SourcesTree.js#193
Here's what the function does: https://lodash.com/docs/#difference
It probably can be replaced with a simple loop
Hi there, I'd love to work on this, is there any other thing I should know about?
|
Reporter | |
Comment 2•3 years ago
|
||
(In reply to Clinton from comment #1)
Hi there, I'd love to work on this, is there any other thing I should know about?
Since you are already working on other bugs, maybe we can keep this one for which it will really be their first bug in DevTools :)
Haha, true, I wasn't working on many bugs when I asked to be assigned but now I would in fact prefer not to be assigned.
|
Assignee | |
Comment 4•2 years ago
|
||
Hi, I see that this issue has been unassigned for 2 months. If we no longer prefer this for someone completely new to devtools, I'd love to work on this.
|
|
Reporter | |
Comment 5•2 years ago
|
||
Hello Sai, I assigned it to you, let me know if you have any question :)
|
|
Assignee | |
Comment 6•2 years ago
|
||
Thanks Nicolas! This looks pretty straightforward. I'll send a patch over the weekend.
|
|
Assignee | |
Comment 7•2 years ago
|
||
|
|
Assignee | |
Comment 8•2 years ago
|
||
Hey Nicolas, I've sent a revision for review. I've marked you as the reviewer. Please let me know if I should ask someone else.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/01987cdc73f1 Replace lodash difference usage with filter. r=nchevobbe
|
||
Comment 10•2 years ago
|
||
| bugherder | ||
Description
•