1737968 - Remove lodash difference usage

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

It seems to only be used from https://searchfox.org/mozilla-central/rev/f8576fec48d866c5f988baaf1fa8d2f8cce2a82f/devtools/client/debugger/src/components/PrimaryPanes/SourcesTree.js#193

Here's what the function does: https://lodash.com/docs/#difference
It probably can be replaced with a simple loop

Comment 1

[Clinton]

Hi there, I'd love to work on this, is there any other thing I should know about?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Clinton from comment #1)

Hi there, I'd love to work on this, is there any other thing I should know about?

Since you are already working on other bugs, maybe we can keep this one for which it will really be their first bug in DevTools :)

Comment 3

[Clinton]

Haha, true, I wasn't working on many bugs when I asked to be assigned but now I would in fact prefer not to be assigned.

Comment 4

[Sai Hemanth]

Hi, I see that this issue has been unassigned for 2 months. If we no longer prefer this for someone completely new to devtools, I'd love to work on this.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Hello Sai, I assigned it to you, let me know if you have any question :)

Comment 6

[Sai Hemanth]

Thanks Nicolas! This looks pretty straightforward. I'll send a patch over the weekend.

Comment 7

[Sai Hemanth]

Attachment: Bug 1737968 - Replace lodash difference usage with filter. r=nchevobbe

Comment 8

[Sai Hemanth]

Hey Nicolas, I've sent a revision for review. I've marked you as the reviewer. Please let me know if I should ask someone else.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01987cdc73f1
Replace lodash difference usage with filter. r=nchevobbe

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/01987cdc73f1