1738012 - 10.24 - 3.76% dailymail fcp / dailymail fnbpaint + 4 more (Android) regression on Thu October 21 2021

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a browsertime performance regression from push bd57366e61d8dd7e794a30eb205804ff7427230d. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
10%	dailymail fcp	android-hw-p2-8-0-android-aarch64-shippable-qr	warm webrender	52.50 -> 57.88
10%	dailymail fcp	android-hw-p2-8-0-android-aarch64-shippable-qr	warm webrender	52.96 -> 58.17
8%	dailymail fcp	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	167.46 -> 181.25
6%	dailymail fnbpaint	android-hw-g5-7-0-arm7-shippable-qr	warm webrender	223.12 -> 235.92
4%	dailymail fcp	android-hw-g5-7-0-arm7-shippable-qr	cold webrender	509.58 -> 529.33
4%	dailymail fnbpaint	android-hw-g5-7-0-arm7-shippable-qr	cold webrender	515.23 -> 534.62

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

I am working with Agi to investigate the issue. This is a patch that is required for a feature shipping in Fenix 95 so backing this out will break downstream builds of Fenix.

https://share.firefox.dev/3bfmlVc

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1738012 - Fetch content meta data only after the page is loaded. r=#geckoview-reviewers,agi

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/jobs?repo=try&revision=5471c76696871224b63fe378a3c449c36d18f797

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca2ff4f605bb
Fetch content meta data only after the page is loaded. r=mconley

Comment 5

[Sandor Molnar[:smolnar]]

Backed out changeset ca2ff4f605bb (bug 1738012) for causing bc failures in browser_startup_content

Backout link: https://hg.mozilla.org/integration/autoland/rev/e6a75ef83e8e4708f87ea00655ff9ffe677dc0ee

Push with failures

Failure log

Comment 6

[Pascal Chevrel (relman team) -> :pascalc]

Gabriel, any update on this issue? Thanks

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

We understand the backout problem fairly well. Will look to land it this week.

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

Too late for 95.

Comment 9

[Dianna Smith [:diannaS]]

Any update on this?

Comment 10

[Chris Peterson [:cpeterson]]

gl, any updates on fixing the backout problem? Fixing a performance regression sounds important.

Comment 11

[Chris Peterson [:cpeterson]]

gl told me he should be able to fix this bug in GV 101.

Comment 12

[Chris Peterson [:cpeterson]]

gl, will you be able to fix this bug in Nightly 102?

Comment 13

[Gabriel Luong [:gl] (ΦωΦ)]

Hi, yes I will get to this next week.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a0d086bae3e
Fetch content meta data only after the page is loaded. r=mconley

Comment 15

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/0a0d086bae3e

Comment 16

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #34263 (as of Wed, 01 Jun 2022 06:40:18 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	dailymail fcp	android-hw-g5-7-0-arm7-shippable-qr	fission warm webrender	206.58 -> 196.38
4%	dailymail PerceptualSpeedIndex	android-hw-g5-7-0-arm7-shippable-qr	fission warm webrender	352.88 -> 338.83
4%	dailymail FirstVisualChange	android-hw-g5-7-0-arm7-shippable-qr	fission warm webrender	334.25 -> 321.17

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34263