1738033 - Run addons-linter checks on the generated langpack manifest

Status: NEW

(Firefox Build System :: General, task, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a follow up to Bug 1732676, it would be good to explicitly run addons-linter on the langpack manifests being generated by langpack_manifest.py, either in the langpack_manifest.py or in the test that is covering it (test_langpack_manifest.py).

Running this additional check would ensure us that the generated langpacks are going to be valid once submitted to AMO (where an addons-linter linting failure would prevent the submittion to complete successfully), and ensure we may caught earlier regressions in the behavior due to changes on the langpack_manifest.py and/or addons-linter sides (e.g. see mozilla/addons-linter#3998).

The following addons-linter checks applies to langpacks:

• the version is in a valid format (See addons-linter schema/format.s)
• checks that langpack's .properties/.ftl/.dtd parse correctly from an addons-linter perspective (See addons-linter LangpackScanner)
• no additional properties are included in the manifest.json file, besides the expected ones (either the generic ManifestBase ones or the WebExtensionLangpackManifest specific ones)