1738034 - Windows startup Crash in [@ winapi_util::console::Console::create_for_stream]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 95.0a1 20211027093708 - update was live only for a short time but already 400 crashes from 100 installations.

Maybe Fission related. (DOMFissionEnabled=1)

Crash report: https://crash-stats.mozilla.org/report/index/88db24f2-704e-426b-ae94-e6d210211027

MOZ_CRASH Reason: assertion failed: !handle.is_null()

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:17
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:91
2 xul.dll core::ops::function::Fn::call<void  ../09c42c45858d5f3aedfa670698275303a3d19afa/library/core/src/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook ../09c42c45858d5f3aedfa670698275303a3d19afa//library/std/src/panicking.rs:628
4 xul.dll std::panicking::begin_panic_handler::closure$0 ../09c42c45858d5f3aedfa670698275303a3d19afa//library/std/src/panicking.rs:519
5 xul.dll std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure$0, never$> ../09c42c45858d5f3aedfa670698275303a3d19afa//library/std/src/sys_common/backtrace.rs:141
6 xul.dll std::panicking::begin_panic_handler ../09c42c45858d5f3aedfa670698275303a3d19afa//library/std/src/panicking.rs:517
7 xul.dll core::panicking::panic_fmt ../09c42c45858d5f3aedfa670698275303a3d19afa//library/core/src/panicking.rs:101
8 xul.dll core::panicking::panic ../09c42c45858d5f3aedfa670698275303a3d19afa//library/core/src/panicking.rs:50
9 xul.dll static winapi_util::console::Console::create_for_stream third_party/rust/winapi-util/src/console.rs:208

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I'm seeing this with my local builds as well. Interestingly, if I launch Firefox from Visual Studio with the debugger attached, it works fine.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

The same build also launches fine if I invoke it with ./mach run.

Comment 3

[Shayne Jewers]

This is also affecting the latest Thunderbird Daily too.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Regressing changes in bug 1736459 have been backed out and new Firefox Nightly updates are available.

Comment 5

[Mike Hommey [:glandium]]

Great... there are more places that can initialize env_logger.