1738091 - Revise CTA telemetry

Status: VERIFIED FIXED

(Firefox :: Pocket, enhancement)

Description

[Gavin Suntop [:gvn] (they/them)]

• Add metadata to the cta_seen ping to reflect Pocket login status.
• Add probe for saving articles to Pocket

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Attachment: Bug 1738091 - CTA Telemetry revision

Comment 2

[Gavin Suntop [:gvn] (they/them)]

Attachment: Data review request

Comment 3

[klong]

Comment on attachment 9249117 [details]
Data review request

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

https://phabricator.services.mozilla.com/D127149
https://phabricator.services.mozilla.com/D130217

Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes. Users can opt-out the data collection by disabling the Firefox telemetry.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Kirill Demtchouk ([e-mail]) will be monitoring those metrics.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

These bug falls under Category 2.

Is the data collection request for default-on or default-off?

Targeting release channel, in en-US.

Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3f0b242a0a3
CTA Telemetry revision r=thecount

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a3f0b242a0a3

Comment 6

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly (Build ID: 20211118212756) on Windows 10 x64, macOS 11.6 and Ubuntu 20.04.

• The telemetry event for saving an article from the CTA Plus Recs module is registered.
• The metadata for the “cta_seen” event is correctly registered and it correctly reflects the Pocket login status.

Comment 7

[Gavin Suntop [:gvn] (they/them)]

[Tracking Requested - why for this release]: Telemetry is needed for pending experiment.

Comment 8

[Gavin Suntop [:gvn] (they/them)]

Comment on attachment 9248952 [details]
Bug 1738091 - CTA Telemetry revision

Beta/Release Uplift Approval Request

• User impact if declined: We will lose needed telemetry to measure user sentiment.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We are using an established telemetry methodology.
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9248952 [details]
Bug 1738091 - CTA Telemetry revision

Approved for 95 beta 11, thanks.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/fb15f1cfc92d

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using Firefox Beta 95.0b11 (Build ID: 20211123190150) on Windows 10 x64, macOS 11.6 and Ubuntu 20.04.

• The telemetry event for saving an article from the CTA Plus Recs module is registered.
• The metadata for “cta_seen” event is correctly registered and it correctly reflects the Pocket login status.