1738104 - Shut down IPDL actors when the thread they're bound to is shut down

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Nika Layzell [:nika] (ni? for response)]

This tracks building upon bug 1738103 to shut down IPDL actors when the nsISerialEventTarget they're bound to is shut down.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1738104 - Shutdown IPC actors during EventTarget shutdown, r=#ipc-reviewers

Depends on D129840

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88be1ad60435
Shutdown IPC actors during EventTarget shutdown, r=ipc-reviewers,mccr8

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/88be1ad60435

Comment 4

[Andrej (:aglavic)]

== Change summary for alert #33695 (as of Tue, 29 Mar 2022 16:59:54 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	Base Content Resident Unique Memory	windows10-64-2004-shippable-qr		9,540,096.00 -> 9,109,162.67
4%	Base Content Resident Unique Memory	windows10-64-2004-shippable-qr		9,427,882.67 -> 9,069,397.33

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33695

Comment 5

[Jens Stutte [:jstutte]]

BTW, I am not sure I like the naming here. We have way too many meanings of "shutdown" and started to move towards ShutdownPhase for general shutdown things to be more precise on when in shutdown. This here has nothing to do with general shutdown, it is just the thread's end. So what about:

RegisterShutdownTask -> RegisterEndOfThreadTask
UnregisterShutdownTask -> UnregisterEndOfThreadTask
RunShutdownTasks -> RunEndOfThreadTasks

?

Comment 6

[Dianna Smith [:diannaS]]

Backed out changeset 88be1ad60435 (bug 1738104) for issues in (bug 1762604), a=backout from 100.0b6

back out link: https://hg.mozilla.org/releases/mozilla-beta/rev/6912c9205930de01ffd34446debbf8fffe92fd9b

Comment 7

[Nika Layzell [:nika] (ni? for response)]

This was only backed out from beta at the time, so it's fixed now.