1738107 - Build warning nsTArray.h:3171:19 [-Wdeprecated-declarations] 'iterator<std::output_iterator_tag, void, void, void, void>' is deprecated

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Markus Stange [:mstange]]

I'm seeing the following build warning many times over, when building on macOS with the macOS 12 SDK and clang 13:

18:49.13 /Users/mstange/code/obj-m-opt/dist/include/nsTArray.h:3171:19: warning: 'iterator<std::output_iterator_tag, void, void, void, void>' is deprecated [-Wdeprecated-declarations]
18:49.13     : public std::iterator<std::output_iterator_tag, void, void, void, void> {
18:49.13                   ^
18:49.13 /Users/mstange/.mozbuild/clang/bin/../include/c++/v1/__iterator/iterator.h:27:29: note: 'iterator<std::output_iterator_tag, void, void, void, void>' has been explicitly marked deprecated here
18:49.13 struct _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX17 iterator
18:49.13                             ^
18:49.13 /Users/mstange/.mozbuild/clang/bin/../include/c++/v1/__config:1016:39: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX17'
18:49.14 #  define _LIBCPP_DEPRECATED_IN_CXX17 _LIBCPP_DEPRECATED
18:49.14                                       ^
18:49.14 /Users/mstange/.mozbuild/clang/bin/../include/c++/v1/__config:993:48: note: expanded from macro '_LIBCPP_DEPRECATED'
18:49.14 #    define _LIBCPP_DEPRECATED __attribute__ ((deprecated))
18:49.14                                                ^
18:49.14 1 warning generated.

Comment 1

[Timothy Nikkel (:tnikkel)]

Also happens for me when building with the default sdk.

Comment 2

[Brad Werth [:bradwerth]]

Looks like std::iterator is marked as deprecated and we need to mark up our iterator classes that derive from it.

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1738107 Part 1: Remove deprecated std::iterator from nsTArrayBackInserter.

Comment 4

[Brad Werth [:bradwerth]]

Attachment: Bug 1738107 Part 2: Remove deprecated std::iterator from ICU4CGlue.

Depends on D130311

Comment 5

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a59f8b56a861c40f5ffa3e826a1ea04649256a6

Comment 6

[Brad Werth [:bradwerth]]

Looks good on try: https://treeherder.mozilla.org/jobs?repo=try&revision=f7601c076c96c29a0d64b62c0ad0cc4a6c855af3

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be058482842c
Part 1: Remove deprecated std::iterator from nsTArrayBackInserter. r=nika

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/be058482842c

Comment 9

[Takanori MATSUURA]

Attachment #9249137 [details] is not published yet.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a804fa919f3
Part 2: Remove deprecated std::iterator from ICU4CGlue. r=gregtatum

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/3a804fa919f3