Closed Bug 1738127 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 31405 - [layout] Fix baseline synthesis.

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
95 Branch
Tracking Flags:
Tracking Status
firefox95 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31405 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31405
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[layout] Fix baseline synthesis.

Previously the APIs:

  • NGBoxFragment::BaselineOrSynthesize
  • NGBoxFragment::FirstBaselineOrSynthesize

Always synthesized baselines from the block-end edge. Typically in a
vertical writing-mode we should be synthesizing from the block-middle,
except when we have "text-orientation: sideways".

This changes the synthesis APIs to accept a FontBaseline parameter
similar to BaselineMetrics to pick the right type of baseline.

Change-Id: I2e153442af659c412b72ce70cc520731d46e83be

Reviewed-on: https://chromium-review.googlesource.com/3243263
WPT-Export-Revision: 7e33d8806d343bc162f21d84ff8681cd642c4f69

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6521a5dcdcd
[wpt PR 31405] - [layout] Fix baseline synthesis., a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/c6521a5dcdcd

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
You need to log in before you can comment on or make changes to this bug.