1738152 - Remove code that is unused after the removal of InternalHitTester

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

In bug 1731700, I am removing InternalHitTester, which contains the remnants of APZ's Layers-specific hit-testing code.

This removal is going to leave some other code unused (for example, certain fields of HitTestingTreeNode), which I plan to remove in this bug.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1738152 - Remove IAPZHitTester methods that were only used by InternalHitTester. r=hiro

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1738152 - Remove the aOutSourceOfOverscrollTransform parameter of APZCTreeManager::ComputeTransformForNode(). r=hiro

This parameter was only used by InternalHitTester.

Depends on D129762

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1738152 - Remove HitTestingTreeNode methods that were only used by InternalHitTester. r=hiro

Depends on D129763

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1738152 - Remove HitTestingTreeNode::mIsBackfaceHidden. r=hiro

Depends on D129764

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1738152 - Remove HitTestingTreeNode::mClipRegion. r=hiro

Depends on D129765

Comment 6

[Botond Ballo [:botond]]

Attachment: Bug 1738152 - Remove TreeBuildingState::mParentHasPerspective. r=hiro

Depends on D129766

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1738152 - Remove HitTestingTreeNode::mEventRegions. r=hiro

Depends on D129767

Comment 8

[Botond Ballo [:botond]]

Attachment: Bug 1738152 - Remove WebRenderScrollDataWrapper methods that are no longer used. r=hiro

Depends on D129768

Comment 9

[Botond Ballo [:botond]]

Attachment: Bug 1738152 - Remove APZCTreeManager::ComputeClipRegion(). r=hiro

Depends on D129767

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cca69a4939e8
Remove IAPZHitTester methods that were only used by InternalHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/9950dbc3a44d
Remove the aOutSourceOfOverscrollTransform parameter of APZCTreeManager::ComputeTransformForNode(). r=hiro
https://hg.mozilla.org/integration/autoland/rev/447743014b43
Remove HitTestingTreeNode methods that were only used by InternalHitTester. r=hiro
https://hg.mozilla.org/integration/autoland/rev/0fd199fcf113
Remove HitTestingTreeNode::mIsBackfaceHidden. r=hiro
https://hg.mozilla.org/integration/autoland/rev/ff5a17a901a0
Remove HitTestingTreeNode::mClipRegion. r=hiro
https://hg.mozilla.org/integration/autoland/rev/0540f06c9748
Remove TreeBuildingState::mParentHasPerspective. r=hiro
https://hg.mozilla.org/integration/autoland/rev/15725ef0978a
Remove APZCTreeManager::ComputeClipRegion(). r=hiro
https://hg.mozilla.org/integration/autoland/rev/b38cf98d505d
Remove HitTestingTreeNode::mEventRegions. r=hiro
https://hg.mozilla.org/integration/autoland/rev/9e1956c27d78
Remove WebRenderScrollDataWrapper methods that are no longer used. r=hiro

Comment 11

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/cca69a4939e8
https://hg.mozilla.org/mozilla-central/rev/9950dbc3a44d
https://hg.mozilla.org/mozilla-central/rev/447743014b43
https://hg.mozilla.org/mozilla-central/rev/0fd199fcf113
https://hg.mozilla.org/mozilla-central/rev/ff5a17a901a0
https://hg.mozilla.org/mozilla-central/rev/0540f06c9748
https://hg.mozilla.org/mozilla-central/rev/15725ef0978a
https://hg.mozilla.org/mozilla-central/rev/b38cf98d505d
https://hg.mozilla.org/mozilla-central/rev/9e1956c27d78