Closed Bug 1738165 Opened 3 years ago Closed 2 years ago

[wpt-sync] Sync PR 31410 - Use gfx::RectF for SVG viewport and viewBox

Categories

(Core :: SVG, task, P4)

task

Tracking

()

RESOLVED INVALID

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31410 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31410
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Use gfx::RectF for SVG viewport and viewBox

SVG viewport and viewBox don't accept negative width/size, so using
gfx::RectF instead of FloatRect will not cause regressions.

Fix a bug that foreignObject may have negative sized bbox when width
or height is negative.

SVGRect is modified to store x, y, width, height separately internally
and exposed to JavaScript so that JavaScript can set and get values
without clamping. However, SVGRect::Rect() is for renderer so it now
uses gfx::RectF which is clamped.

Bug: 738465
Change-Id: Ia6016aeae0699a8a5b29992d736d12e11184f993

Reviewed-on: https://chromium-review.googlesource.com/3248707
WPT-Export-Revision: 6f3e6d60636b7d47062600f3b3f526ff2efa6e67

Component: web-platform-tests → SVG
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.