Add a `production-filter` command to searchfox-tool / the test_insta_glob test mechanism to avoid check brittleness for production checks
Categories
(Webtools :: Searchfox, enhancement)
Tracking
(Not tracked)
People
(Reporter: asuth, Assigned: asuth)
References
Details
Attachments
(2 files)
Bug 1737298 and bug 1735343 are examples of where minor changes to indexed content that shifted line numbers or symbol indexes in ANALYSIS_DATA resulted in indexer errors. As discussed in those bugs, we should add a means of normalizing these specific numeric values so they don't matter for production checks but we can still have more detailed checks in our test repositories where the inputs won't undergo random permutations.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
This is probably fixed. I hot-patched the config1 indexer that started ~34 minutes ago (by checking out the changes and running cargo build --release). This will be a good test of the normalization because the normalized data was generated from the last good run, not the failed bad run.
|
|
Assignee | |
Comment 4•4 years ago
|
||
This needed a minor follow-up to further improve the revised blame filtering. When moving from the regexp to the lol_html selector-based HTML filtering there was a regression that I caught but ended up dropping on the floor.
There was an erroring diff this afternoon that looks like:
1 │- <div role="cell"><div class="cov-strip cov-no-data"></div></div>
1 │+ <div role="cell"><div class="cov-strip cov-hit cov-interpolated" role="button" aria-label="uncovered"></div></div>
The original regexp approach (which applied to the test corpus too, which is why I removed it) removed both the outer div and the inner div. The intent in the production-filter was to retain the outer div and strip the inner div with the classes out of existence because this div has metadata on it, but the combination of selector I ended up using (:has isn't supported I think) and method didn't match up right. Now fixed.
https://github.com/mozsearch/mozsearch/pull/460
https://github.com/mozsearch/mozsearch-mozilla/pull/155
Description
•