Closed Bug 17382 Opened 25 years ago Closed 25 years ago

missing forward slash in URL will not load

Categories

(Core :: Networking, defect, P3)

Product:
Core
Component:
Networking
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: iShaterin, Assigned: andreas.otte)

References

(
URL
)

Details

(Whiteboard: [PDT+])

Attachments

(1 file)

I use this exception in navigator.js to catch failed urlloads
897 bytes, patch
Details | Diff | Splinter Review 
If a user enters a URL with only one forward slash into the location box and
presses ENTER the browser crashes.

For that matter if the user enters http:/, http: , or http:/// (3 or more /'s)
the browser crashes.

I'm  using the most current build 10/26/99
Assignee: don → gagan
Component: Browser-General → Necko
Depends on: 13449
No longer depends on: 13449
Blocks: 13449
Target Milestone: M11
Is this a real crash or just an uncaught JS exception?
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I don't see this crash on win32 or linux builds from 11/5.
marking fixed.  reopen if there still is a problem. thx
Resetting QA contact from leger.
Status: RESOLVED → REOPENED
This is almost fixed--i'm not sure if this needs to be written up as a seperate
bug, but it seems part of the fix to this bug so I'll report it here.  The
browser no longer crashes if only one slash is included (i.e.
http:/www.somesite.com) the new problem is that the fix just adds two forward
slashes resulting in a total of three (e.g. the previous url resolves to
http:///www.somesite.com) While the browser no longer crashes it also doesn't go
to the site.

I guess this could be considering functions as designed but it seems some smarts
are in order here.  If we are already adding two forward slashes if none are
present, shouldn't we add just one if only one slash is present?
This is an urlparser problem. It does not catch the :/ case, thinks this is a
file url and puts /www.mozilla.org into the path(!), adding // to the scheme,
resulting in http:///www.mozilla.org which will not load because there is no
host.
Resolution: FIXED → ---
Summary: missing forward slash in URL causes the browser to crash → missing forward slash in URL will not load
Clearing FIXED resolution due to reopen.
Target Milestone: M11 → M12
Moving milestone from M11 to M12
Moving Assignee from gagan to warren since he is away.
The urlparser has to know if there is a host expected or not. This is the
nsHostURL/nsNoHostURL stuff. See bug 18148.
Moving what's not done for M12 to M13.
Bulk move of all Necko (to be deleted component) bugs to new Networking

component.
Assignee: warren → andreas.otte
assigning this bug to me per Warrens request
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Fixed by Andreas' changes that I just checked in.
Status: RESOLVED → REOPENED
reopened because of backout
Target Milestone: M13 → M14
This will not make it into M13
Resolution: FIXED → ---
Clearing FIXED resolution due to reopen.
Keywords: beta1
Putting on PDT+ radar for beta1.
Whiteboard: [PDT+]
This is fixed now
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
verified:
Linux 2000020708
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: