Closed
Bug 173827
Opened 22 years ago
Closed 22 years ago
NSPR l10n_debug cruft copied into jsprf.c from old prprf.c
Categories
(Core :: JavaScript Engine, defect, P3)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla1.3alpha
People
(Reporter: brendan, Assigned: brendan)
Details
(Keywords: js1.5)
Attachments
(3 files)
3.11 KB,
patch
|
Details | Diff | Splinter Review | |
6.86 KB,
patch
|
scole
:
review+
|
Details | Diff | Splinter Review |
6.83 KB,
patch
|
Details | Diff | Splinter Review |
Cc'ing wtc in case it's still there. The getenv call seems save enough to me, and the l10n_debug boolean conditions safe-looking printfs, but all this junk should be #ifdef DEBUG, if it shouldn't be removed altogether. wtc, do you know the history? I'll dig into cvs if that contains the answer, although this may well predate cvs.mozilla.org. /be
Assignee | ||
Updated•22 years ago
|
Comment 1•22 years ago
|
||
I know the history but it's not important. I think all that stuff should be removed altogether. It is still in prprf.c.
Assignee | ||
Comment 2•22 years ago
|
||
I also eliminated tabs, stripped trailing whitespace, fixed else-after-break non-sequiturs, and consolidated a break or two. /be
Comment 3•22 years ago
|
||
Can I also make the suggestion that we change _LEFT, _SIGNED, _SPACED, _ZEROS, and _NEG with tokens that don't begin with an underscore? We had a compiler once that used _LEFT, and this was a problem here... [I realize that this bug isn't here to address this, but if jsprf is getting cleaned up it fits. Sort of.] --scole
Assignee | ||
Comment 4•22 years ago
|
||
scole, how about an r=? I'll get this in today with that. /be
Comment 5•22 years ago
|
||
Comment on attachment 106140 [details] [diff] [review] fix with scole's suggested further cleanup Looks good to me. (Thanks for taking my suggestion, Brendan.)
Attachment #106140 -
Flags: review+
Assignee | ||
Comment 6•22 years ago
|
||
Fixed on the trunk. /be
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 7•22 years ago
|
||
This is Brendan's patch (attachment 106140 [details] [diff] [review]) adjusted for NSPR's prprf.c. I've checked it in on the trunk of NSPR.
You need to log in
before you can comment on or make changes to this bug.
Description
•