Closed Bug 1738375 Opened 3 months ago Closed 2 months ago

Annotate crash reports with Windows app package name and publisher

Categories

(Toolkit :: Application Update, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
96 Branch
Tracking Status
firefox96 --- verified

People

(Reporter: nalexander, Assigned: bhearsum)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidedi-tikka])

Attachments

(2 files)

This ticket tracks annotating crash reports with the current Windows app package name and publisher (or package full name), to let us distinguish app package-specific crashes from regular installation crashes.

Whiteboard: [ → [fidedi-tikka]

Nick, correct me if I'm wrong, but I believe that https://phabricator.services.mozilla.com/D130188 covers most or all of this (and may be committed with the wrong bug number?).

Severity: -- → S3
Flags: needinfo?(nalexander)
Priority: -- → P1

(In reply to bhearsum@mozilla.com (:bhearsum) from comment #1)

Nick, correct me if I'm wrong, but I believe that https://phabricator.services.mozilla.com/D130188 covers most or all of this (and may be committed with the wrong bug number?).

You are correct: it's a start on this work, and the bug number is incorrect. Please take it and roll with it! (I'll push the background task annotations, the first commit IIRC, across the line.)

Flags: needinfo?(nalexander)
Assignee: nobody → bhearsum
Attachment #9251242 - Attachment description: WIP: Bug 1738375: Annotate crash reports with Windows app package name and publisher → Bug 1738375: Annotate crash reports with Windows app package name and publisher. r?gsvelto!
Attached file datareview.txt

(It's unclear to me if I'm supposed to put your name in here, Chris, but I couldn't submit without one...)

Attachment #9251373 - Flags: data-review?(chutten)

Comment on attachment 9251373 [details]
datareview.txt

PRELIMINARY NOTES:
Any Data Steward listed in the wiki should be able to help you with your Data Review Requests, including me.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :bhearsum is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Attachment #9251373 - Flags: data-review?(chutten) → data-review+
Pushed by bhearsum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df662e82d825
Annotate crash reports with Windows app package name and publisher. r=gsvelto

For posterity, the data review requested here also applies to https://bugzilla.mozilla.org/show_bug.cgi?id=1737108 where we're collecting the same piece of data through Telemetry.

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch

Hello! Are there any steps that we could use to verify this issue? Thank you!

Flags: needinfo?(bhearsum)

(In reply to Alexandru Trif, QA [:atrif] from comment #9)

Hello! Are there any steps that we could use to verify this issue? Thank you!

Yes! You should be able to verify by:

  1. Forcing a crash (about:crashparent)
  2. Before submitting the crash report, opening the crash .extra file (should be in %appdata%\Mozilla\Firefox\Crash Reports\Pending)
  3. Verifying that "WindowsPackageFamilyName" is present in the above file
Flags: needinfo?(bhearsum)

Thank you!

Verified on Windows 10x64 and Windows 11x64 with Firefox MSIX 96.0a1 (20211125095031) that the WindowsPackageFamilyName string is present in the .extra file inside the Crash Reports\Pending folder while the submit crash report window is displayed.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.