Closed Bug 1738378 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 31428 - [@layer] Implement layer serialization in @import rules

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31428 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31428
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

[@layer] Implement layer serialization in @import rules

This patch also fixes a bug in ConsumeAtRulePrelude that the result
prelude may contain leading white spaces. The new test requires the fix
to pass.

Bug: 1095765
Change-Id: Ie565309d38aa208aa0e60b5c862ec1e62a5764b2
Reviewed-on: https://chromium-review.googlesource.com/3252521
WPT-Export-Revision: fa26a14aa8f8d919e65e4dd33472c49972787d5a

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 13 subtests

Status Summary

Firefox

OK : 1
FAIL: 13

Chrome

OK : 1
PASS: 4
FAIL: 9

Safari

OK : 1
PASS: 4
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-cascade/parsing/layer-import.html
@import url("nonexist.css") layer(); should still be a valid import rule with an invalid layer declaration: FAIL
@import url("nonexist.css") layer(A B); should still be a valid import rule with an invalid layer declaration: FAIL
@import url("nonexist.css") layer(A . B); should still be a valid import rule with an invalid layer declaration: FAIL
@import url("nonexist.css") layer(A, B, C); should still be a valid import rule with an invalid layer declaration: FAIL

New Tests That Don't Pass

/css/css-cascade/parsing/layer-import.html
@import url("nonexist.css") layer; should be a valid layered import rule: FAIL (Chrome: FAIL, Safari: FAIL)
@import url("nonexist.css") layer(A); should be a valid layered import rule: FAIL (Chrome: FAIL, Safari: FAIL)
@import url("nonexist.css") layer(A.B); should be a valid layered import rule: FAIL (Chrome: FAIL, Safari: FAIL)
@import url(nonexist.css) layer; should be a valid layered import rule: FAIL (Chrome: FAIL, Safari: FAIL)
@import url(nonexist.css) layer(A); should be a valid layered import rule: FAIL (Chrome: FAIL, Safari: FAIL)
@import url(nonexist.css) layer(A.B); should be a valid layered import rule: FAIL (Chrome: FAIL, Safari: FAIL)
@import "nonexist.css" layer; should be a valid layered import rule: FAIL (Chrome: FAIL, Safari: FAIL)
@import "nonexist.css" layer(A); should be a valid layered import rule: FAIL (Chrome: FAIL, Safari: FAIL)
@import "nonexist.css" layer(A.B); should be a valid layered import rule: FAIL (Chrome: FAIL, Safari: FAIL)
@import url("nonexist.css") layer(); should still be a valid import rule with an invalid layer declaration: FAIL (Chrome: PASS, Safari: PASS)
@import url("nonexist.css") layer(A B); should still be a valid import rule with an invalid layer declaration: FAIL (Chrome: PASS, Safari: PASS)
@import url("nonexist.css") layer(A . B); should still be a valid import rule with an invalid layer declaration: FAIL (Chrome: PASS, Safari: PASS)
@import url("nonexist.css") layer(A, B, C); should still be a valid import rule with an invalid layer declaration: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68dac38d4a02
[wpt PR 31428] - [@layer] Implement layer serialization in @import rules, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3186051e24f0
[wpt PR 31428] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.