1738400 - Fix -Wshadow-field-in-constructor-modified warning in js/src/vm/SavedStacks.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Bug 1247299 added a column member variable reduce differential testing false positives, but the SavedFrame::Lookup constructor inadvertently sets the constructor's column parameter = 0, not the column member variable.

js/src/vm/SavedStacks.cpp:198:14 [-Wshadow-field-in-constructor-modified] modifying constructor parameter 'column' that shadows a field of 'js::SavedFrame::Lookup'

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1738400 - Fix -Wshadow-field-in-constructor-modified warning in js/src/vm/SavedStacks.cpp. r?sfink

Bug 1247299 added a column member variable reduce differential testing false positives, but the SavedFrame::Lookup constructor inadvertently sets the constructor's column parameter = 0, not the column member variable.

js/src/vm/SavedStacks.cpp:198:14 [-Wshadow-field-in-constructor-modified] modifying constructor parameter 'column' that shadows a field of 'js::SavedFrame::Lookup'

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f398c3d4e213
Fix -Wshadow-field-in-constructor-modified warning in js/src/vm/SavedStacks.cpp. r=sfink

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f398c3d4e213