Closed Bug 1738583 Opened 2 years ago Closed 2 years ago

Handle Thunderbird related "ESLint rule no-loss-of-precision" (rule enabled in bug 1730126)

Categories

(Thunderbird :: Upstream Synchronization, task, P3)

Tracking

(thunderbird_esr91 unaffected, thunderbird94 unaffected)

RESOLVED FIXED
95 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird94 --- unaffected

People

(Reporter: mkmelin, Assigned: riasangwan1999)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1730126 +++

Following bug 1730126 we have some adjustments to make.

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/base/src/CalRecurrenceInfo.jsm:175:25 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/base/src/CalRecurrenceInfo.jsm:176:24 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/memory/CalMemoryCalendar.jsm:447:22 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/CalStorageModel.jsm:248:22 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/CalStorageModel.jsm:251:19 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/calStorageHelpers.jsm:177:21 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/calStorageHelpers.jsm:179:20 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/calStorageHelpers.jsm:179:56 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/unit/test_recur.js:278:6 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/test/unit/test_nsIMsgFolderCache.js:54:30 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/test/unit/test_nsIMsgFolderCache.js:55:44 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/test/unit/test_nsIMsgFolderCache.js:56:31 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/test/unit/test_nsIMsgFolderCache.js:57:45 | This number literal will lose precision at runtime. (no-loss-of-precision) 

I would love work on this, if it's open to work.

Yes, if you're fast ;)
We'll want to fix it within the next day or so since the comm-central linting job is now yellow.

Just give me a day, I'll do my best.

Assignee: nobody → riasangwan1999
Status: NEW → ASSIGNED

Thanks for the quick fix! Maybe you want to work on other Thunderbird bugs as well? Perhaps bug 1727181?

Target Milestone: --- → 95 Branch

Welcome. :)

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d87c87325a37
Handle Thunderbird related "ESLint rule no-loss-of-precision". r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.