1738583 - Handle Thunderbird related "ESLint rule no-loss-of-precision" (rule enabled in bug 1730126)

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task, P3)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1730126 +++

Following bug 1730126 we have some adjustments to make.

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/base/src/CalRecurrenceInfo.jsm:175:25 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/base/src/CalRecurrenceInfo.jsm:176:24 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/memory/CalMemoryCalendar.jsm:447:22 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/CalStorageModel.jsm:248:22 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/CalStorageModel.jsm:251:19 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/calStorageHelpers.jsm:177:21 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/calStorageHelpers.jsm:179:20 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/providers/storage/calStorageHelpers.jsm:179:56 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/calendar/test/unit/test_recur.js:278:6 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/test/unit/test_nsIMsgFolderCache.js:54:30 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/test/unit/test_nsIMsgFolderCache.js:55:44 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/test/unit/test_nsIMsgFolderCache.js:56:31 | This number literal will lose precision at runtime. (no-loss-of-precision)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/mailnews/base/test/unit/test_nsIMsgFolderCache.js:57:45 | This number literal will lose precision at runtime. (no-loss-of-precision) 

Comment 1

[Riya]

I would love work on this, if it's open to work.

Comment 2

[Magnus Melin [:mkmelin]]

Yes, if you're fast ;)
We'll want to fix it within the next day or so since the comm-central linting job is now yellow.

Comment 3

[Riya]

Just give me a day, I'll do my best.

Comment 4

[Intermittent Failures Robot]

2 failures in 2845 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform and build breakdown:

• lint: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1738583&startday=2021-10-25&endday=2021-10-31&tree=all

Comment 5

[Riya]

Attachment: Bug 1738583 - Handle Thunderbird related "ESLint rule no-loss-of-precision". r?mkmelin

Comment 6

[Magnus Melin [:mkmelin]]

Thanks for the quick fix! Maybe you want to work on other Thunderbird bugs as well? Perhaps bug 1727181?

Comment 7

[Riya]

Welcome. :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d87c87325a37
Handle Thunderbird related "ESLint rule no-loss-of-precision". r=mkmelin