Closed Bug 1738604 Opened 4 years ago Closed 4 years ago

In the Write Window, the Address book Drop down has invisible text: black text on black background

Categories

(Thunderbird :: Message Compose Window, defect)

Thunderbird 91
Unspecified
Windows 10
defect

Tracking

(thunderbird_esr91+ verified, thunderbird95+ fixed)

VERIFIED FIXED
96 Branch
Tracking Status
thunderbird_esr91 + verified
thunderbird95 + fixed

People

(Reporter: cccol, Assigned: Paenglab)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36 Edg/94.0.992.50

Steps to reproduce:

With multiple address books (one for Business and one for personal). I click on the Write menu option to open a compose message window. In the address book sidebar, select the Address Book drop down to select the address book I want to use.

Actual results:

The drop down menu appears with a black background and black text.

Expected results:

Text color needs to be changed to white to match the rest of the drop downs in Thunderbird. Alternately, let us choose the background and text colors for the dropdown menus.

What operating system theme and Thunderbird theme are you using?

Flags: needinfo?(cccol)

(In reply to WaltS48 [:walts48] from comment #2)

What operating system theme and Thunderbird theme are you using?

Standard Win 10 theme and Blue Ocean Gradient T-Bird theme

Flags: needinfo?(cccol)

(In reply to cccol from comment #3)

(In reply to WaltS48 [:walts48] from comment #2)

What operating system theme and Thunderbird theme are you using?

Standard Win 10 theme and Blue Ocean Gradient T-Bird theme

I can't find that theme to test in https://addons.thunderbird.net/en-US/thunderbird/static-themes/, but the issue is probably with the add-on, and the developer needs to make it compatible.

(In reply to WaltS48 [:walts48] from comment #4)

(In reply to cccol from comment #3)

(In reply to WaltS48 [:walts48] from comment #2)

What operating system theme and Thunderbird theme are you using?

Standard Win 10 theme and Blue Ocean Gradient T-Bird theme

I can't find that theme to test in https://addons.thunderbird.net/en-US/thunderbird/static-themes/, but the issue is probably with the add-on, and the developer needs to make it compatible.

Thanks, I will send a blurb to the add-on developer!

(In reply to WaltS48 [:walts48] from comment #4)

I can't find that theme to test in https://addons.thunderbird.net/en-US/thunderbird/static-themes/, but the issue is probably with the add-on, and the developer needs to make it compatible.

No, the issue is with all dark LW-themes. You can try Dark Fox dor example.

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Found Blue Ocean Gradient and Dark Fox on addons.mozilla.org using my Firefox browser.
Saved both and can't install either one in my 91.2.0 on Fedora 34 because they appear to be corrupt.

I guess I could try on Windows, but not really that interested.

OS: Unspecified → Windows 10

This is Windows 10 only because it has special -moz-windows-non-native-menus mode.
To test use a dark LW-theme (not the dark theme). All menus should be now light again.

With the dark system theme and a dark LW-theme Daily uses all dark but shows the trees wrong. But with TB 91 it is still light. So a new bug introduced by toolkit which I'm fixing in a new bug.

Attachment #9248877 - Flags: review?(alessandro)
Comment on attachment 9248877 [details] [diff] [review] 1738604-LW-theme-no-dark-menu.patch Review of attachment 9248877 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks
Attachment #9248877 - Flags: review?(alessandro) → review+
Target Milestone: --- → 96 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/af5a069f4cfb
[Windows 10] Don't use the dark menus with dark LW-themes. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment on attachment 9248877 [details] [diff] [review]
1738604-LW-theme-no-dark-menu.patch

[Approval Request Comment]
User impact if declined: With dark system theme and dark LW-theme unreadable popups
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9248877 - Flags: approval-comm-esr91?
Attachment #9248877 - Flags: approval-comm-beta?

Comment on attachment 9248877 [details] [diff] [review]
1738604-LW-theme-no-dark-menu.patch

[Triage Comment]
Approved for beta

Attachment #9248877 - Flags: approval-comm-beta? → approval-comm-beta+
Regressions: 1740407

Comment on attachment 9248877 [details] [diff] [review]
1738604-LW-theme-no-dark-menu.patch

[Triage Comment]
Approved for esr91

Attachment #9248877 - Flags: approval-comm-esr91? → approval-comm-esr91+

Verified using the Dark Fox theme installed into the 91.3.1 rc on Windows 10. Default OS theme.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: