1738637 - js-types produces "funcref" not "anyfunc"

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Lars T Hansen [:lth]]

Consider:

js> var t = new WebAssembly.Table({element:"anyfunc", initial:0})
js> t.type()
({element:"anyfunc", minimum:0})

The change in https://github.com/WebAssembly/js-types/pull/34/files requires "funcref" on output here, as the canonical name for this type.

Also funcref must be accepted everywhere on input, eg, in table descriptors. We have no tests for this, we should add them. It does seem to be supported, however (cursorily tested).

Comment 1

[Lars T Hansen [:lth]]

There are various WPTs, which will need to be updated.

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1738637 - wasm: Emit 'funcref' instead of 'anyfunc' for .type() accessors. r?yury

The specification for js-types now [1] defines the canonical type used
for .type() accessors to be 'funcref' instead of 'anyfunc'. The implementation
and WPTs are updated accordingly. 'anyfunc' is still accepted as an alias of
'funcref' for constructors, but this is already implemented and requires no
changes.

[1] https://github.com/WebAssembly/js-types/pull/34/files
[2] https://github.com/WebAssembly/js-types/blob/main/proposals/js-types/Overview.md

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30e72f02feba
wasm: Emit 'funcref' instead of 'anyfunc' for .type() accessors. r=yury

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34468 for changes under testing/web-platform/tests

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/30e72f02feba

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot