173867 - http expires header with date-in-past causes miscalculation

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Tom Everingham]

Overview Description:  An http expires header with a date in the past sometimes
causes browser to miscalculate the expiration time of a page.  In this case, I
send out an expires of 'Thu, 01 Dec 1969 16:00:00 GMT' which the browser
interprets as a future date of '01/06/06 14:28:15'.   This causes the stale
version of the page to be pulled from cache when it should be coming from the
network.

Steps to Reproduce:
1.)  click on the url to send out the expires: '1969' header to the browser
(sorry, internal only)
2.)  type about:cache to check the expires date

Actual Results:  date is miscalculated to the year 2006

Build Date & Platform Bug Found:  2002101015 winNT

Additional Builds and Platforms Tested On:
works on mac osX
linux rh6 and rh7.1 gives me expires: can't get timezone

Comment 1

[Tom Everingham]

Attachment: packet trace and what is displayed in about:cache

Comment 2

[Darin Fisher]

tever: HTTP/1.1 requires a Date header.  can you try adding a Date header to see
if that fixes the problem?  we may be having this problem only when there is no
Date header.

Comment 3

[Tom Everingham]

darin:  I added the header "Date: Friday, 11-Oct-02 12:12:12 GMT" and I am still
seeing the same thing.  The expires is still ending up as year 06.

Comment 4

[Darin Fisher]

ok, thanks for trying that tom.  i'll take it from here.

Comment 5

[Darin Fisher]

-> moz 1.3

Comment 6

[Jaime Rodriguez, Jr.]

This does not seem specific to embeddors. Topembed-/nsbeta1+.

Comment 7

[Darin Fisher]

no, but it may cause site compatibility issues, and it is a standards violation.
 i would think embedders would care about such things.

re-nominating.

Comment 8

[Chris Nalls]

Marking topembed+ as result of Topembed triage

Comment 9

[Darin Fisher]

-> suresh

Comment 10

[Suresh]

Attachment: patch attached.

The problem is PR_ParseTimeString returns negative number for this case.

Comment 11

[Darin Fisher]

Comment on attachment 113139 [details] [diff] [review]
patch attached.

suresh: looks good, but please keep the indentation consistent with the rest of
the file. thx!

sr=darin

Comment 12

[Suresh]

fixed in trunk.

Comment 13

[Tom Everingham]

verified:  2003040708 win NT trunk