Closed Bug 1738731 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 31458 - Fix interactionId when click gets the wrong PointerId

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox96 fixed)

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 31458 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/31458
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

Fix interactionId when click gets the wrong PointerId

Since click events sometimes do not get the correct PointerId, we use
the last PointerId of a pointerdown or pointerup seen. But we also
take care to reset this last seen when we see other kinds of events,
to prevent the click from being accidentally attributed to an
interaction in the past that did not trigger it.

Bug: 1264930
Change-Id: Ieb5773f3a6c9a9cfd46b428b5a925c4535060386
Reviewed-on: https://chromium-review.googlesource.com/3255225
WPT-Export-Revision: 09a2389190fe066b8f39ff9c028faa4e67b530fa

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/event-timing/click-interactionid.html
Event Timing: compare event timing interactionId.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d572669ec17 [wpt PR 31458] - Fix interactionId when click gets the wrong PointerId, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.