1738890 - send mail hangs forever while posting news entry with to: header - TypeError: messageFile is null SmtpService.jsm

Status: RESOLVED FIXED

(MailNews Core :: Networking: SMTP, defect)

Description

[Stephan Sachse]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36

Steps to reproduce:

send news post with to: header

Actual results:

news is posted fine, but the email is not send. send dialog hangs forever. there is a logmessage

TypeError: messageFile is null SmtpService.jsm:121:9 (resource:///modules/SmtpService.jsm)

Expected results:

mail should be sent

Comment 1

[Wayne Mery (:wsmwk)]

Confirmed

Comment 2

[Alfred Peters [:infofrommozilla]]

Here the parameter (file) seems to be missing:
https://searchfox.org/comm-central/rev/37baa8dd18341e3dd3083347c3b91292b6cddcc9/mailnews/compose/src/MessageSend.jsm#624

    this._deliverFileAsMail();

=> this._deliverFileAsMail(this._deliveryFile);

That seems a little too easy to me!?

Comment 3

[Ping Chen [:rnons] (away)]

Attachment: Bug 1738890 - Fix sending mail together with posting news. r=mkmelin

Comment 4

[Ping Chen [:rnons] (away)]

Thanks Alfred.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d03a0ec5d8a3
Fix sending mail together with posting news. r=mkmelin

Comment 6

[Ping Chen [:rnons] (away)]

Comment on attachment 9249658 [details]
Bug 1738890 - Fix sending mail together with posting news. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1211292
User impact if declined: When sending mail together with posting news, the mail will fail
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): low

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9249658 [details]
Bug 1738890 - Fix sending mail together with posting news. r=mkmelin

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 95.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/0d67836bb3e3

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9249658 [details]
Bug 1738890 - Fix sending mail together with posting news. r=mkmelin

[Triage Comment]
Approved for ers91

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9249658 [details]
Bug 1738890 - Fix sending mail together with posting news. r=mkmelin

[Triage Comment]
correcting flag

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 91.4.0:
https://hg.mozilla.org/releases/comm-esr91/rev/4a3a7e8367e6