Closed
Bug 1738899
Opened 4 years ago
Closed 4 years ago
Assert that gray marking doesn't push black entries
Categories
(Core :: JavaScript: GC, task, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
While looking into bug 1724599 I noticed we check whether gray marking pushes black entries to the mark stack. As far as I can see this should no longer happen since bug 1717553, so we should assert this and remove the check.
| Assignee | ||
Comment 1•4 years ago
|
||
Also assert that nothing adds entries to the barrier buffer.
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d24482057dd
Assert that gray marking doesn't push black entries r=sfink
Comment 3•4 years ago
|
||
Backed out for causing mochitest failures on Marking.cpp
Flags: needinfo?(jcoppeard)
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/538616c847b9
Assert that gray marking doesn't push black entries r=sfink
Comment 5•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
| Assignee | ||
Updated•1 year ago
|
Flags: needinfo?(jcoppeard)
You need to log in
before you can comment on or make changes to this bug.
Description
•