Closed Bug 1738943 Opened 3 years ago Closed 2 years ago

Python 3.10 "PY_SSIZE_T_CLEAN macro must be defined for '#' formats"

Tracking

(Not tracked)

Status:

RESOLVED FIXED

People

(Reporter: mhentges, Unassigned)

References

(Blocks 1 open bug)

Details

Mitchell Hentges [:mhentges] 🦀

Reporter

Description

•

3 years ago

•

Edited

To reproduce

Use Python 3.10 (this may be Linux-specific)
Have fsmonitor enabled
hg up central

~/d/firefox % hg up central
** Unknown exception encountered with possibly-broken third-party extension "clang-format" (version N/A)
** which supports versions 5.3 of Mercurial.
** Please disable "clang-format" and try your action again.
** If that fixes the bug please report it to https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox%20Build%20System&component=Lint%20and%20Formatting
** Python 3.10.0 (default, Oct  4 2021, 00:00:00) [GCC 11.2.1 20210728 (Red Hat 11.2.1-1)]
** Mercurial Distributed SCM (version 5.9.3)
** Extensions loaded: absorb, blackbox, clang-format, evolve 10.4.0, firefoxtree, fsmonitor, histedit, js-format, push-to-try, rebase, show
Traceback (most recent call last):
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/__init__.py", line 830, in _state
    self.repo._watchmanclient.command(
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/watchmanclient.py", line 119, in command
    return self._command(*args)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/watchmanclient.py", line 106, in _command
    return self._watchmanclient.query(*watchmanargs)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/pywatchman/__init__.py", line 1156, in query
    self._connect()
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/pywatchman/__init__.py", line 1024, in _connect
    self.sockpath = self._resolvesockname()
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/pywatchman/__init__.py", line 1007, in _resolvesockname
    result = bser.loads(stdout)
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/commandserver.py", line 499, in _serverequest
    sv.serve()
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/commandserver.py", line 403, in serve
    while self.serveone():
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/commandserver.py", line 377, in serveone
    handler(self)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/chgserver.py", line 583, in runcommand
    return super(chgcmdserver, self).runcommand()
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/commandserver.py", line 358, in runcommand
    ret = self._dispatchcommand(req) & 255
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/commandserver.py", line 297, in _dispatchcommand
    return dispatch.dispatch(req)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/dispatch.py", line 250, in dispatch
    status = _rundispatch(req)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/dispatch.py", line 294, in _rundispatch
    ret = _runcatch(req) or 0
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/dispatch.py", line 470, in _runcatch
    return _callcatch(ui, _runcatchfunc)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/dispatch.py", line 480, in _callcatch
    return scmutil.callcatch(ui, func)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/scmutil.py", line 153, in callcatch
    return func()
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/dispatch.py", line 460, in _runcatchfunc
    return _dispatch(req)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/dispatch.py", line 1273, in _dispatch
    return runcommand(
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/dispatch.py", line 918, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/dispatch.py", line 1285, in _runcommand
    return cmdfunc()
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/dispatch.py", line 1271, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/util.py", line 1886, in check
    return func(*args, **kwargs)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/util.py", line 1886, in check
    return func(*args, **kwargs)
  File "/home/mitch/.mozbuild/evolve/hgext3rd/evolve/__init__.py", line 554, in wrapmayobsoletewc
    res = origfn(ui, repo, *args, **opts)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/util.py", line 1886, in check
    return func(*args, **kwargs)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/commands.py", line 7848, in update
    ret = hg.updatetotally(
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/hg.py", line 1180, in updatetotally
    ret = _update(repo, checkout, updatecheck=updatecheck)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/hg.py", line 1099, in update
    stats = mergemod.update(repo[node], updatecheck=updatecheck)
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/merge.py", line 2196, in update
    return _update(
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/__init__.py", line 890, in wrapupdate
    with state_update(
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/__init__.py", line 788, in __enter__
    self.enter()
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/__init__.py", line 803, in enter
    self.need_leave = self._state(b'state-enter', hex(self.oldnode))
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/hgext/fsmonitor/__init__.py", line 849, in _state
    self.repo.ui.log(
  File "/home/mitch/.local/pipx/venvs/mercurial/lib64/python3.10/site-packages/mercurial/ui.py", line 2126, in log
    msg = msgfmt % msgargs
TypeError: %b requires a bytes-like object, or an object that implements __bytes__, not 'SystemError'

Workaround

Edit ~/.hgrc and comment-out (#) the fsmonitor = line.

Other details

This affects Python 3.10+
Mercurial issue is here
Root issue is over here

Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]

Comment 1

•

2 years ago

Use Python 3.10 (this may be Linux-specific)

I reproduced this on macOS 11.6.1 today with hg 6.0 and python 3.9.9. The workaround worked for me.

Mark Banner (:standard8)

Comment 2

•

2 years ago

Adding to mach-busted to make it easier to find. It looks like the Mercurial fix has landed but is not currently released.

Blocks: mach-busted

Mark Banner (:standard8)

Comment 3

•

2 years ago

Also, I'm seeing this bustage on Mac across all of our custom extensions. I ended up downgrading Mercurial in homebrew to work around it:

Download an older version of the mercurial definition
Then run:

$ brew uninstall --ignore-dependencies mercurial
$ brew install mercurial.rb
$ brew pin mercurial

The 'pin' stops brew updating mercurial, so don't forget to unpin it once the new version is out.

Comment hidden (obsolete)

I am having the same issue on arch linux here. The workaround from the description solved the hg failures, but then I get an error when I want to use moz-phab:

$ moz-phab
Traceback (most recent call last):
  File "/home/jens/.local/bin/moz-phab", line 33, in <module>
    sys.exit(load_entry_point('MozPhab==0.1.99', 'console_scripts', 'moz-phab')())
  File "/home/jens/.local/bin/moz-phab", line 22, in importlib_load_entry_point
    for entry_point in distribution(dist_name).entry_points
  File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 919, in distribution
    return Distribution.from_name(distribution_name)
  File "/usr/lib/python3.10/importlib/metadata/__init__.py", line 518, in from_name
    raise PackageNotFoundError(name)
importlib.metadata.PackageNotFoundError: No package metadata was found for MozPhab

I tried a mach bootstrap after applying above workaround (and without enabling fsmonitor) to no avail.
Obviously this has nothing to do with the linter itself, should I file a new bug?

Edit: re-installing moz-phab fixed this, so probably unrelated.

Lars T Hansen [:lth]

Comment 6

•

2 years ago

Seen on Fedora 35 today; Fedora 34 was OK.

Mitchell Hentges [:mhentges] 🦀

Reporter

Comment 7

•

2 years ago

This should be solved on Mercurial 6.0.1+, which is working correctly on my machines

Status: NEW → RESOLVED

Closed: 2 years ago

Resolution: --- → FIXED

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

Python 3.10 "PY_SSIZE_T_CLEAN macro must be defined for '#' formats"

Categories

(Developer Services :: General, defect)

Tracking

(Not tracked)

People

(Reporter: mhentges, Unassigned)

References

(Blocks 1 open bug)

Details

Crash Data

Security

(public)

User Story

Description

To reproduce

Workaround

Other details

Comment 1

Comment 2

Comment 3

Comment 5

Comment 6

Comment 7