1739042 - Lack of contrast in win7/8 context menus with dark theme.

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Thorin [:thorin]]

Attachment: context-menus.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

moz-regression leads to Bug 1738616

Windows 7 here with ui.systemUsesDarkTheme = 1 - see pic

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Why are you overriding ui.systemUsesDarkTheme? Does it repro without systemUsesDarkTheme but with a dark Firefox theme?

Comment 2

[Thorin [:thorin]]

A Dark theme on Windows 7 leaves the tabstrip transparent with no color (some bug about aero?) By using ui.systemUsesDarkTheme and system theme, I can get that tabstrip dark (and not transparent)

Changing to Dark Theme and deleting ui.systemUsesDarkTheme (and restarting for good measure) does not fix the issue

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1738616

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1739042 - Force Windows' native context menus to be light. r=#desktop-theme-reviewers

Since the native theme doesn't draw dark menus.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ec283f776cf
Force Windows' native context menus to be light. r=desktop-theme-reviewers,dao

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9ec283f776cf

Comment 7

[Thorin [:thorin]]

just updated, confirmed fixed

Comment 8

[Thorin [:thorin]]

yikes, was that meant to happen resolved to fixed?

Comment 9

[Emilio Cobos Álvarez (:emilio)]

I don't understand, what is the question?

Comment 10

[Thorin [:thorin]]

nvm, if you didn't see anything untoward, then I guess Status: RESOLVED → VERIFIED as in, "did I do the right thing, am I allowed to" is OK

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Yeah that's totally fine :)

Comment 12

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 96.0a1 (2021-11-02) under Windows 7.

The issue is fixed on Firefox 96.0. Tested on the same system.