Closed Bug 1739042 Opened 3 years ago Closed 3 years ago

Lack of contrast in win7/8 context menus with dark theme.

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Version:
Firefox 96
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox94 --- unaffected
firefox95 --- unaffected
firefox96 --- verified

People

(Reporter: simon.mainey, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

context-menus.png
33.36 KB, image/png
Details
Bug 1739042 - Force Windows' native context menus to be light. r=#desktop-theme-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Attached image context-menus.png —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

moz-regression leads to Bug 1738616

Windows 7 here with ui.systemUsesDarkTheme = 1 - see pic

Component: Untriaged → Layout
Product: Firefox → Core
Version: Firefox 91 → Firefox 96
Regressions: 1738616
No longer regressions: 1738616

Why are you overriding ui.systemUsesDarkTheme? Does it repro without systemUsesDarkTheme but with a dark Firefox theme?

Flags: needinfo?(simon.mainey)
Regressed by: 1738616
Has Regression Range: --- → yes

A Dark theme on Windows 7 leaves the tabstrip transparent with no color (some bug about aero?) By using ui.systemUsesDarkTheme and system theme, I can get that tabstrip dark (and not transparent)

Changing to Dark Theme and deleting ui.systemUsesDarkTheme (and restarting for good measure) does not fix the issue

Flags: needinfo?(simon.mainey)
Flags: needinfo?(emilio)

Set release status flags based on info from the regressing bug 1738616

status-firefox94: --- → unaffected
status-firefox95: --- → unaffected
status-firefox96: --- → affected
status-firefox-esr91: --- → unaffected
Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Component: Layout → Theme
Ever confirmed: true
Flags: needinfo?(emilio)
Product: Core → Firefox
Summary: ui.systemUsesDarkTheme vs context menu → Lack of contrast in win7/8 context menus with dark theme.

Since the native theme doesn't draw dark menus.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ec283f776cf
Force Windows' native context menus to be light. r=desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/9ec283f776cf

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox96: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch

just updated, confirmed fixed

Status: RESOLVED → VERIFIED

yikes, was that meant to happen resolved to fixed?

Flags: needinfo?(emilio)

I don't understand, what is the question?

Flags: needinfo?(emilio) → needinfo?(simon.mainey)

nvm, if you didn't see anything untoward, then I guess Status: RESOLVED → VERIFIED as in, "did I do the right thing, am I allowed to" is OK

Flags: needinfo?(simon.mainey)

Yeah that's totally fine :)

QA Whiteboard: [qa-96b-p2]

Reproduced the issue on Firefox 96.0a1 (2021-11-02) under Windows 7.

The issue is fixed on Firefox 96.0. Tested on the same system.

QA Whiteboard: [qa-96b-p2]
status-firefox96: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: