Closed Bug 1739367 Opened 4 years ago Closed 4 years ago

Use std::tuple instead of mozilla::Tuple in widget/

Categories

(Core :: General, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: ssummar, Assigned: ssummar)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.54 Safari/537.36

Blocks: 1276351
Depends on: 1603127, 1738840

Hi, I created this bug to replace mozilla::Tuple usages in widget/ with std::tuple. I'll be publishing a patch soon.

This bug depends on two other bugs

  • Bug 1603127
    In widget/gtk/nsClipboard.cpp there is callsite for mozilla::Decoder::DecodeToUTF16(...) (linked here). This was migrated to std::tuple in bug 1603127.

  • Bug 1738840
    In widget/windows/WinHeaderOnlyUtils.h is a function definition for mozilla::ModuleVersion::AsTuple (linked here). This was migrated to std::tuple in bug 1738840.

Instead of making these changes again, I added these bugs as dependecies for this bug.

(In reply to Shazib Summar from comment #1)

Hi, I created this bug to replace mozilla::Tuple usages in widget/ with std::tuple. I'll be publishing a patch soon.

THe bigger goal is to push bug 1276351 forward step by step.

Assignee: nobody → ssummar.bee16seecs
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac834d7ed488 Replaces mozilla::Tuple with std::tuple in widget/ r=emilio,geckoview-reviewers,owlish
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: