1739381 - Add profiler marker for each AudioNode with their type, and AudioWorkletProcessor.process with the Processor name

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement)

Comment 1

[amabb]

Attachment: Bug 1739381 - Add TRACE macros in all AudioNodeEngine sub classes ProcessBlock and ProcessBlocksOnPorts methods. r=padenot

Comment 2

[amabb]

Attachment: Bug 1739381 - Add TRACE macros in all AudioNodeEngine sub classes ProcessBlock and ProcessBlocksOnPorts methods. r=padenot

Depends on D145167

Comment 3

[amabb]

Attachment: Bug 1739381 - Add the correct header file for TRACE macro in corresponding files. r=padenot

Depends on D147438

Comment 4

[amabb]

Attachment: Bug 1739381 - Resolve error in ConvolverNode class. r=padenot

Depends on D148236

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D145167	Bug 1739381 - Add profiler marker for an AudioWorkletProcessor. r=padenot	amabb	padenot: Resigned from review

:amabb, could you please find another reviewer?

For more information, please visit auto_nag documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 7

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fcfb99bfb91
Add TRACE macros in all AudioNodeEngine sub classes ProcessBlock and ProcessBlocksOnPorts methods. r=padenot

Comment 9

[Norisz Fay [:noriszfay]]

Backed out for causing build bustage on AudioNodeEngine.cpp

Backout link

Push with failures

Failure log

Failure line: /builds/worker/checkouts/gecko/dom/media/webaudio/AudioNodeEngine.cpp:397:3: error: use of undeclared identifier 'TRACE'

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6b7d45fef16
Add TRACE macros in all AudioNodeEngine sub classes ProcessBlock and ProcessBlocksOnPorts methods. r=padenot

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c6b7d45fef16