Closed
Bug 1739515
Opened 3 years ago
Closed 3 years ago
Clean up preference for supporting multiple PiP windows
Categories
(Toolkit :: Picture-in-Picture, task, P3)
Toolkit
Picture-in-Picture
Tracking
()
RESOLVED
FIXED
97 Branch
| Tracking | Status | |
|---|---|---|
| firefox97 | --- | fixed |
People
(Reporter: mtigley, Assigned: rhopkinsdev)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [pip-needs-eng-triage])
Attachments
(1 file)
We have a preference that enables opening multiple PiP windows: media.videocontrols.picture-in-picture.allow-multiple. This was meant to support rollout and has already been shipping for a while.
This issue looks at removing those checks to assume full support and clean up the code:
- https://searchfox.org/mozilla-central/rev/a12c2c2e59c92d8f969d8f3f290ab16919449c9d/toolkit/components/pictureinpicture/PictureInPicture.jsm#358-363
- https://searchfox.org/mozilla-central/rev/a12c2c2e59c92d8f969d8f3f290ab16919449c9d/toolkit/components/pictureinpicture/PictureInPicture.jsm#104-108
- https://searchfox.org/mozilla-central/rev/a12c2c2e59c92d8f969d8f3f290ab16919449c9d/toolkit/components/pictureinpicture/PictureInPicture.jsm#915-920
- https://searchfox.org/mozilla-central/rev/a12c2c2e59c92d8f969d8f3f290ab16919449c9d/toolkit/components/pictureinpicture/PictureInPicture.jsm#32-33
|
||
Updated•3 years ago
|
Component: Video/Audio Controls → Picture-in-Picture
Version: unspecified → Trunk
|
Reporter | |
Updated•3 years ago
|
Assignee: nobody → rhopkinsdev
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/21ee85dead9f Remove checks for multiple PiP windows pref r=mtigley,kpatenio,mhowell,preferences-reviewers
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•