mozdevice logs adb server response with extra data as warning
Categories
(Testing :: Mozbase Rust, enhancement)
Tracking
(firefox96 fixed)
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: bugs, Assigned: bugs)
Details
Attachments
(3 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0
Steps to reproduce:
Use mozdevice to connect to a device with adb
Actual results:
the extra data (beyond just OKAY/FAIL) is logged with log level warn, together with the hex length and the actual length of the remaining Vec
Expected results:
Only if the hex length and the remaining Vec size differ should a warning be logged. The response data should be logged on debug level
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d07c279e45e8 [mozdevice-rust] Reduce log line for extra adb data from "warn" to "debug". r=whimboo,webdriver-reviewers https://hg.mozilla.org/integration/autoland/rev/602918a34ee6 [mozdevice-rust] Remove deprecated `extern crate` lines. r=whimboo,webdriver-reviewers https://hg.mozilla.org/integration/autoland/rev/683d1f1978e6 [mozdevice-rust] Replace manual prefix checks with starts_with. r=whimboo,webdriver-reviewers
|
||
Comment 5•1 year ago
|
||
kpcyrd, thanks for your fixes! To better triage these kind of bugs please file further issues with mozdevice under Testing : Mozbase Rust.
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d07c279e45e8
https://hg.mozilla.org/mozilla-central/rev/602918a34ee6
https://hg.mozilla.org/mozilla-central/rev/683d1f1978e6
Description
•