Closed Bug 1739536 Opened 10 months ago Closed 9 months ago

mozdevice logs adb server response with extra data as warning

Categories

(Testing :: Mozbase Rust, enhancement)

Default
enhancement

Tracking

(firefox96 fixed)

RESOLVED FIXED
96 Branch
Tracking Status
firefox96 --- fixed

People

(Reporter: bugs, Assigned: bugs)

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

Use mozdevice to connect to a device with adb

Actual results:

the extra data (beyond just OKAY/FAIL) is logged with log level warn, together with the hex length and the actual length of the remaining Vec

Expected results:

Only if the hex length and the remaining Vec size differ should a warning be logged. The response data should be logged on debug level

Assignee: nobody → bugs

Depends on D130412

Attachment #9249332 - Attachment description: Bug 1739536 - Remove deprecated `extern crate` lines. r=whimboo → Bug 1739536 - [mozdevice-rust] Remove deprecated `extern crate` lines.
Attachment #9249331 - Attachment description: Bug 1739536 - Reduce log line for extra adb data from "warn" to "debug". r=whimboo → Bug 1739536 - [mozdevice-rust] Reduce log line for extra adb data from "warn" to "debug".
Attachment #9249333 - Attachment description: Bug 1739536 - Replace manual prefix checks with starts_with. r=whimboo → Bug 1739536 - [mozdevice-rust] Replace manual prefix checks with starts_with.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d07c279e45e8
[mozdevice-rust] Reduce log line for extra adb data from "warn" to "debug". r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/602918a34ee6
[mozdevice-rust] Remove deprecated `extern crate` lines. r=whimboo,webdriver-reviewers
https://hg.mozilla.org/integration/autoland/rev/683d1f1978e6
[mozdevice-rust] Replace manual prefix checks with starts_with. r=whimboo,webdriver-reviewers

kpcyrd, thanks for your fixes! To better triage these kind of bugs please file further issues with mozdevice under Testing : Mozbase Rust.

Status: UNCONFIRMED → NEW
Component: General → Mozbase Rust
Ever confirmed: true
You need to log in before you can comment on or make changes to this bug.