Menu's and dialog interaction is sluggish during page loads

VERIFIED FIXED in mozilla1.2beta

Status

()

P1
normal
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: kmcclusk, Assigned: kmcclusk)

Tracking

({perf, topembed})

Trunk
mozilla1.2beta
x86
Windows XP
perf, topembed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

16 years ago
When loading a long page Mozilla's menus are not always responsive to user input. 

1. Load
http://lxr.mozilla.org/seamonkey/source/layout/html/style/src/nsCSSFrameConstructor.cpp
2. Save it as a local file.
3. Load the local file.
4. Try opening menu's in mozilla or mfcembed while loading the local file.
5. Also try the find dialog box while loading the local file and enter search text

What happens:
The menus will not always open immediately. They are sluggish and sometimes they
don't update until the mouse is moved.

The dialog boxes are also sluggish.
(Assignee)

Comment 1

16 years ago
Created attachment 102584 [details] [diff] [review]
Fix sluggishness by setting plevent performance hint
(Assignee)

Updated

16 years ago
Keywords: mozilla1.2, nsbeta1+, topembed
Priority: -- → P1
Target Milestone: --- → mozilla1.2beta
(Assignee)

Comment 2

16 years ago
Created attachment 102585 [details] [diff] [review]
Same as last patch with improved comments
(Assignee)

Updated

16 years ago
Attachment #102584 - Attachment is obsolete: true

Comment 3

16 years ago
Comment on attachment 102585 [details] [diff] [review]
Same as last patch with improved comments

r=rods
Attachment #102585 - Flags: review+

Comment 4

16 years ago
Comment on attachment 102585 [details] [diff] [review]
Same as last patch with improved comments

sr=kin@netscape.com

There are no other ways out of the content sink without the performance hint
being reset back right? Even when the user hits cancel?
Attachment #102585 - Flags: superreview+
(Assignee)

Comment 5

16 years ago
The performance hint should always be set back. 

DidBuildModel which resets the performance hint is called even if the user hits
cancel. DidBuildModel is called when the parser is terminated either through
completion of the parsing, or canceling the parsing. 

I tested:
 hitting cancel part way through document loading. 
 Interupting the load of a long document by specifying a new URL.  
 Closing a browser window when it was part way through loading a long document.

All cases work fine. DidBuildModel was called and the flag is reset.
(Assignee)

Updated

16 years ago
Keywords: approval
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
Keywords: perf

Comment 6

16 years ago
Comment on attachment 102585 [details] [diff] [review]
Same as last patch with improved comments

a=asa for checkin to 1.2beta (on behalf of drivers)
Attachment #102585 - Flags: approval+
(Assignee)

Comment 7

16 years ago
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Updated

16 years ago
QA Contact: rakeshmishra → trix

Comment 8

16 years ago
verified on latest mozilla trunk build 2002122608
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.