173956 - Menu's and dialog interaction is sluggish during page loads

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Kevin McCluskey (gone)]

When loading a long page Mozilla's menus are not always responsive to user input. 

1. Load
http://lxr.mozilla.org/seamonkey/source/layout/html/style/src/nsCSSFrameConstructor.cpp
2. Save it as a local file.
3. Load the local file.
4. Try opening menu's in mozilla or mfcembed while loading the local file.
5. Also try the find dialog box while loading the local file and enter search text

What happens:
The menus will not always open immediately. They are sluggish and sometimes they
don't update until the mouse is moved.

The dialog boxes are also sluggish.

Comment 1

[Kevin McCluskey (gone)]

Attachment: Fix sluggishness by setting plevent performance hint

Comment 2

[Kevin McCluskey (gone)]

Attachment: Same as last patch with improved comments

Comment 3

[rods (gone)]

Comment on attachment 102585 [details] [diff] [review]
Same as last patch with improved comments

r=rods

Comment 4

[kinmoz]

Comment on attachment 102585 [details] [diff] [review]
Same as last patch with improved comments

sr=[e-mail]

There are no other ways out of the content sink without the performance hint
being reset back right? Even when the user hits cancel?

Comment 5

[Kevin McCluskey (gone)]

The performance hint should always be set back. 

DidBuildModel which resets the performance hint is called even if the user hits
cancel. DidBuildModel is called when the parser is terminated either through
completion of the parsing, or canceling the parsing. 

I tested:
 hitting cancel part way through document loading. 
 Interupting the load of a long document by specifying a new URL.  
 Closing a browser window when it was part way through loading a long document.

All cases work fine. DidBuildModel was called and the flag is reset.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 102585 [details] [diff] [review]
Same as last patch with improved comments

a=asa for checkin to 1.2beta (on behalf of drivers)

Comment 7

[Kevin McCluskey (gone)]

Fix checked into trunk.

Comment 8

[Trix Supremo]

verified on latest mozilla trunk build 2002122608