Closed Bug 1739617 Opened 3 years ago Closed 3 years ago

Permanent dom/promise/tests/test_webassembly_compile.html | loaded from cache and dom/tests/mochitest/fetch/test_responseReadyForWasm.html | nsICacheInfoChannel available when Gecko 96 merges to Beta on 2021-12-06

Categories

(Core :: DOM: Networking, defect, P2)

Product:
Core
Component:
DOM: Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox93 --- unaffected
firefox94 --- unaffected
firefox95 --- fixed
firefox96 + fixed

People

(Reporter: aryx, Assigned: yury)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1739617 - Disable wasm cache tests if pref is off. r?nbp
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

Yep, I forgot about added test. I'll enable it only when preference is enabled.

Assignee: nobody → ydelendik
Flags: needinfo?(ydelendik)

Two tests assume that wasm caching is always enabled:

  • dom/promise/tests/test_webassembly_compile.html
  • dom/tests/mochitest/fetch/test_responseReadyForWasm.html

Fixing that.

Patch works in today's beta-sim.

Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by ydelendik@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d15ef37f371
Disable wasm cache tests if pref is off. r=nbp

Comment on attachment 9249452 [details]
Bug 1739617 - Disable wasm cache tests if pref is off. r?nbp

Beta/Release Uplift Approval Request

  • User impact if declined: automation tests will fail for release
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: D130403
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): low, disables tests
  • String changes made/needed:
Attachment #9249452 - Flags: approval-mozilla-beta?

https://hg.mozilla.org/mozilla-central/rev/8d15ef37f371

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch

Comment on attachment 9249452 [details]
Bug 1739617 - Disable wasm cache tests if pref is off. r?nbp

Low risk, approved for 95 beta 6, thanks.

Attachment #9249452 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: