Closed
Bug 1739618
Opened 3 years ago
Closed 2 years ago
Move "developer" object definition to the `ManifestBase` in json schema
Categories
(WebExtensions :: General, enhancement, P3)
WebExtensions
General
Tracking
(firefox96 fixed)
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: willdurand, Assigned: willdurand)
References
Details
(Whiteboard: [addons-jira])
Attachments
(1 file)
The developer object, which can override author and homepage_url when defined, is currently defined in the WebExtensionManifest type but it is very likely a mistake. Given its purpose, it should be defined in the ManifestBase type, where both author and homepage_url are defined.
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 1•3 years ago
|
||
This patch moves the developer definition to the ManifestBase near
the author and homepage_url props that this object is supposed to
override when defined.
The test case checks that dictionaries, langpacks and static themes can
now override author and homepage_url using the developer object,
which wasn't possible before. The test case fails without the change in
the json schema, so that's covered as well.
|
||
Updated•3 years ago
|
Assignee: nobody → wdurand
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Severity: -- → N/A
Pushed by wdurand@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a1e9b04fe1c3 Move 'developer' object definition to the 'ManifestBase' schema type. r=rpl
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•