1739666 - Messaging system should use feature.variables.enabled, not feature.enabled

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, defect, P1)

Description

[Kate Hudson :k88hudson]

After deprecating .enabled in experimenter, we discovered messaging system is still using the old property. We should update it to use feature.variables.enabled

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1739666 - Messaging system should use feature.variables.enabled, not feature.enabled

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b04b4f5c324d
Messaging system should use feature.variables.enabled, not feature.enabled r=k88hudson

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for newtab failures. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/792b7fca03f5398f64042cbd9070c38cd6100f9b

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=b04b4f5c324d81a016a87bb58d0efb57ff97a013&selectedTaskRun=KJQNqLF6SI-uBo9o1JsmTg.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=357646210&repo=autoland&lineNumber=388

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b13c1db634c
Messaging system should use feature.variables.enabled, not feature.enabled r=k88hudson

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0b13c1db634c

Comment 6

[Andrei Oprea [:andreio]]

Comment on attachment 9249768 [details]
Bug 1739666 - Messaging system should use feature.variables.enabled, not feature.enabled

Beta/Release Uplift Approval Request

• User impact if declined: We want this change as part of the TCP rollout experiment bug 1731713 for Firefox 95.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We have tests covering this change and this has been verified by QA as part of the testing for bug 1738206 (comment 14).
• String changes made/needed:

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9249768 [details]
Bug 1739666 - Messaging system should use feature.variables.enabled, not feature.enabled

Approved for 95.0b6

Comment 8

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b13fcfe77092