1739691 - Media player no longer focused when clicking on background

Status: VERIFIED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[royvandervegt]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

I listen to mp3 files using the builtin player of Firefox (e.g. https://podcasts.robstenders.nl/podcasts/bonanza/2021-11-05_(14-16)-bonanza.mp3).

Actual results:

I can no longer use my keyboard to interact with the player after clicking the grey background. I am unable to pause the player with the space bar and unable to change the volume/skip using the arrow keys.
Only when I click the actual player (so not the background) the keyboard shortcuts work again. I think this is a focus issue.

Expected results:

The keyboard shortcuts should also work when focusing the background (as it did in Fx 93 and prior versions).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: UI Events & Focus Handling' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

I got this regression window - Bug 1724243

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1724243

Comment 4

[Henri Sivonen (:hsivonen)]

WFM on Linux, Windows, and Mac.

Comment 5

[Henri Sivonen (:hsivonen)]

Sorry, I read the steps to repro wrong. Indeed, this is broken after clicking the background.

Comment 6

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1739691 - Make keyboard shortcuts for media documents work after clicking outside the media element.

Comment 7

[Henri Sivonen (:hsivonen)]

The fix itself is very simple, but let's see if the test works:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a2bf9bd8ab73783b6b67c1da81864b63646f3f2

Comment 8

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=773fb951207cc71759b727b7a80c4365af666e66

Comment 9

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=47a5b14849f880ee951a83ba676b2e22620d3c4f

Comment 10

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d7020e63e6f0ad7def98a4111fcb1d90f7e8770

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcd76a911c97
Make keyboard shortcuts for media documents work after clicking outside the media element. r=dholbert

Comment 12

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/fcd76a911c97

Comment 13

[Ardelean Oana, Desktop QA [:oardelean]]

I managed to reproduce this issue on Firefox 100.0(20220428192727) on macOS 11. Verified as fixed on Firefox 101.0b4(20220508185621) and Nightly 102.0a1(20220509190429) on macOS, Ubuntu 20.04 and Win10-64 bits.