Closed Bug 1739693 Opened 11 months ago Closed 11 months ago

[Linux] Weird double border on popups

Categories

(Thunderbird :: Theme, task)

Unspecified
Linux

Tracking

(thunderbird_esr91 unaffected, thunderbird95 unaffected)

RESOLVED FIXED
96 Branch
Tracking Status
thunderbird_esr91 --- unaffected
thunderbird95 --- unaffected

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(3 files, 1 obsolete file)

Attached image linux-popup.png

Since M-C added a drop shadow to popups themeable menupopups have a double border.

Since around TB95 the menupopups follow the TB theme and we don't need to theme them (except Windows 7/8.1). So I removed the code from shared file and added it to the Windows @media not (-moz-windows-non-native-menus) part.

On Linux the menupopups 8px less wide because there is a margin added to give space for the drop shadow.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9249484 - Flags: review?(alessandro)
Comment on attachment 9249484 [details] [diff] [review]
1739693-no-themeable-popups.patch

Review of attachment 9249484 [details] [diff] [review]:
-----------------------------------------------------------------

This is good as it fixes the double styling problem.
On Linux, the menuitems are very large. Is this maybe an issue with elementary OS stylesheet, or the density? (screenshot in the next message)

::: mail/themes/shared/mail/themeableDialog.css
@@ -345,5 @@
> -button menupopup menu,
> -button menupopup menuitem,
> -menulist menupopup menu,
> -menulist menupopup menuitem {
> -  appearance: none;

Removing this appearance: none; makes the menuitem very large.
Attachment #9249484 - Flags: review?(alessandro) → feedback+
Attached image menulist.png

Better like this?

Attachment #9249484 - Attachment is obsolete: true
Attachment #9249854 - Flags: review?(alessandro)
Comment on attachment 9249854 [details] [diff] [review]
1739693-no-themeable-popups.patch

Review of attachment 9249854 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.
Attachment #9249854 - Flags: review?(alessandro) → review+
Target Milestone: --- → 96 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/94e09a3944fa
Don't use the themeable menupopups on Linux and Windows 10. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Regressions: 1740523
You need to log in before you can comment on or make changes to this bug.