1739693 - [Linux] Weird double border on popups

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Description

[Richard Marti (:Paenglab)]

Attachment: linux-popup.png

Since M-C added a drop shadow to popups themeable menupopups have a double border.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1739693-no-themeable-popups.patch

Since around TB95 the menupopups follow the TB theme and we don't need to theme them (except Windows 7/8.1). So I removed the code from shared file and added it to the Windows @media not (-moz-windows-non-native-menus) part.

On Linux the menupopups 8px less wide because there is a margin added to give space for the drop shadow.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9249484 [details] [diff] [review]
1739693-no-themeable-popups.patch

Review of attachment 9249484 [details] [diff] [review]:
-----------------------------------------------------------------

This is good as it fixes the double styling problem.
On Linux, the menuitems are very large. Is this maybe an issue with elementary OS stylesheet, or the density? (screenshot in the next message)

::: mail/themes/shared/mail/themeableDialog.css
@@ -345,5 @@
> -button menupopup menu,
> -button menupopup menuitem,
> -menulist menupopup menu,
> -menulist menupopup menuitem {
> -  appearance: none;

Removing this appearance: none; makes the menuitem very large.

Comment 3

[Alessandro Castellani [:aleca]]

Attachment: menulist.png

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1739693-no-themeable-popups.patch

Better like this?

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9249854 [details] [diff] [review]
1739693-no-themeable-popups.patch

Review of attachment 9249854 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/94e09a3944fa
Don't use the themeable menupopups on Linux and Windows 10. r=aleca