1739937 - Unexpected exception TypeError: can't access property "endsWith", marker.data.filename is undefined at Z:/task_1636322741/build/tests/xpcshell/tests/tools/profiler/tests/xpcshell/head.js:131

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P3)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've seen this happen in this Try, log.

The test marker.data?.filename.endsWith(filename) assumes that there is always a "filename" field in a "FileIO" marker, but it's not true if the IOInterposer could not retrieve a filename.
So the test should really be marker.data?.filename?.endsWith(filename), note the added ? after filename.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1739937 - "FileIO" markers may be missing the "filename" property - r?canaltinova

If the IOInterposer cannot retrieve a filename, the "filename" property is not even written in the marker "data" payload. So its presence should be checked before trying to use JS string functions on it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d228d29a68be
"FileIO" markers may be missing the "filename" property - r=canaltinova

Comment 3

[Julien Wajsberg [:julienw]]

I checked that in the frontend types, we properly marked this property as optional.

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d228d29a68be

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

(In reply to Julien Wajsberg [:julienw] from comment #3)

I checked that in the frontend types, we properly marked this property as optional.

Good idea, thank you for checking.