173995 - flawfinder warnings in nsMsgUtf7Utils.cpp

Status: RESOLVED WORKSFORME

(MailNews Core :: Networking, defect)

Description

[Stephen P. Morse]

Heikki ran flawfinder (http://www.dwheeler.com/flawfinder) on Mozilla 1.0.1 
branch.

flawfinder found 1 warnings in nsMsgUtf7Utils.cpp (3730). Go through
that list and for each warning:

* If it is false positive, comment here why it is not an issue
* If it is a real issue, make patch for it here and let's get them checked in

In addition to checking the branch, also check the trunk.

3730) mailnews/base/util/nsMsgUtf7Utils.cpp:172 [4] (buffer) strcat: does not 
check for buffer overflows. Consider using strncat or strlcat.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Closing all open flawfinder bugs as WORKSFORME because we now have much better tools that do the same (well, better) kind of analysis (Coverity, Klocwork).