Closed Bug 174005 Opened 22 years ago Closed 22 years ago

flawfinder warnings in mailnews/localization

Categories

(MailNews Core :: Localization, defect)

x86
Windows NT
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED INVALID

People

(Reporter: morse, Assigned: nhottanscp)

References

Details

Heikki ran flawfinder (http://www.dwheeler.com/flawfinder) on Mozilla 1.0.1 
branch.

flawfinder found 1 warning in mailnews/localization code (3817). Go through
that list and for each warning:

* If it is false positive, comment here why it is not an issue
* If it is a real issue, make patch for it here and let's get them checked in

In addition to checking the branch, also check the trunk.

3817) mailnews/local/src/nsLocalMailFolder.cpp:2243 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.
Blocks: 148251
-> naoki.
Assignee: rchen → nhotta
This usage is safe, we copy a fixed size to fixed size, and we have enough room
to copy safely.

Marking invalid.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → INVALID
verified as such
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.