174005 - flawfinder warnings in mailnews/localization

Status: VERIFIED INVALID

(MailNews Core :: Localization, defect)

Description

[Stephen P. Morse]

Heikki ran flawfinder (http://www.dwheeler.com/flawfinder) on Mozilla 1.0.1 
branch.

flawfinder found 1 warning in mailnews/localization code (3817). Go through
that list and for each warning:

* If it is false positive, comment here why it is not an issue
* If it is a real issue, make patch for it here and let's get them checked in

In addition to checking the branch, also check the trunk.

3817) mailnews/local/src/nsLocalMailFolder.cpp:2243 [4] (buffer) strcpy: does 
not check for buffer overflows. Consider using strncpy or strlcpy.

Comment 1

[rchen]

-> naoki.

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

This usage is safe, we copy a fixed size to fixed size, and we have enough room
to copy safely.

Marking invalid.

Comment 3

[marina]

verified as such