1740212 - Implement nsLocalFile::GetDiskCapacity on Windows

Status: RESOLVED FIXED

(Core :: XPCOM, task, P2)

Description

[Jan Varga [:janv]]

We are adding a new nsIFile attribute in bug 1735717 and the initial patch implements it only on unix/mac. We need Windows implementation as well.

Comment 1

[Jan Varga [:janv]]

Jari, can you take this ?
Thanks.

Comment 2

[Jari Jalkanen]

(In reply to Jan Varga [:janv] from comment #1)

Jari, can you take this ?
Thanks.

Done!

Comment 3

[Jari Jalkanen]

To avoid misunderstandings, should this return the total size of the hard drive, or total size of the OS partition, or the total size available to the user, or something else?

Comment 4

[Jan Varga [:janv]]

(In reply to Jari Jalkanen from comment #3)

To avoid misunderstandings, should this return the total size of the hard drive, or total size of the OS partition, or the total size available to the user, or something else?

I think returning total size of the hard drive doesn't make sense. It should be related to the file/directory which nsIFile represents, so total size of the OS partition is probably what we want here. The Unix implementations takes into account quota limits, so the total size available to the user would be even better it seems.

I quickly looked at the GetDiskSpaceAvailable implementation on Windows and it uses GetDiskFreeSpaceExW. I would probably use the same function in GetDiskCapacity.

Comment 5

[Jari Jalkanen]

Attachment: Bug 1740212 - Get disk capacity on Windows. r=#dom-storage-reviewers

Depends on D130640

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9732cf85df9f
Get disk capacity on Windows. r=dom-storage-reviewers,janv,xpcom-reviewers,nika DONTBUILD

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9732cf85df9f