1740284 - Missing Unlock in WebGPUParent::RecvSwapChainPresent()

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

There's a missing Unlock() in WebGPUParent::RecvSwapChainPresent(), when it calls ForwardError() and then returns IPC_OK(). (Note another method in the same file avoids this problem in the same code pattern.)

The root cause of this is probably using raw Lock/Unlock's, and not using MutexAutoLock, which would work just fine in all the places we lock in this file.

Comment 1

[Dzmitry Malyshau [:kvark]]

Thank you for finding this out!

Comment 2

[Dzmitry Malyshau [:kvark]]

Attachment: Bug 1740284 properly serialize mUseWebGPU

Try push:
https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=B9FaCqZWTFCThhdPqA4ZPQ.3&revision=33918b139eff008a9cb99b0b4fece919e5e55c8

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Is this patch attached to the correct bug? This is about a missing Unlock...

Comment 4

[Phabricator Automation]

Comment on attachment 9251258 [details]
Bug 1740284 properly serialize mUseWebGPU

Revision D131448 was moved to bug 1740165. Setting attachment 9251258 [details] to obsolete.

Comment 5

[Dzmitry Malyshau [:kvark]]

Randell, thanks for spotting this! I had 2 bugs open and pasted the wrong number :)

Comment 6

[Dzmitry Malyshau [:kvark]]

MutexAutoLock could work but we actually want to unlock earlier than the end of scope. So using MutexAutoLock would require introduction of an artificial scope, at which point it becomes closer to explicit unlocking.

Comment 7

[Dzmitry Malyshau [:kvark]]

Attachment: Bug 1740284 - WebGPU: unlock presentation buffers on error

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b20d2b6b8800
WebGPU: unlock presentation buffers on error r=jimb

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b20d2b6b8800