1740291 - modify ModuleURLRewriteRule

Status: RESOLVED FIXED

(Socorro :: Processor, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Breakpad minidump-stackwalk had an issue where where if the sym file came from the disk cache, it would use the first url in the symbol_urls list which was wrong in a bunch of cases. That's bug #1672406.

Socorro "works around" that by stomping on the symbol_url field with https://symbols.mozilla.org/try/THING .

ModuleURLRewrite code: https://github.com/mozilla-services/socorro/blob/1a7a443e5084355759d9a32c8305111177611bfa/socorro/processor/rules/mozilla.py#L1143-L1173

Once we switch to rust-minidump, we should remove this rule.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

One wry twist is what to do when the url is to a "private place". Should Socorro have a rule that knows about the private places and stomps on the symbol_url field? It might be easy because "private place" is accessed using a localhost proxy.

Need to think about how to do that right.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this to figure out whether we should do it or not.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I think we need to keep this rule to deal with private bucket symbols. We can adjust the rule so that for localhost urls (accessing the private bucket via the local signing proxy), it could wipe out the url or change it to "private".

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I re-read the code--it's only kicking off when the aws signing proxy is involved and that's fine. I already addressed the issue in the description as part of an update to a newer rust-minidump in bug #1759591. Marking as FIXED.